Bug 93308 - [chromium] Convert WebScrollbarThemeGeometry from a concrete class to an interface
Summary: [chromium] Convert WebScrollbarThemeGeometry from a concrete class to an inte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-06 16:31 PDT by Adrienne Walker
Modified: 2012-08-06 20:00 PDT (History)
10 users (show)

See Also:

Attachments
Patch (55.42 KB, patch)
2012-08-06 16:39 PDT, Adrienne Walker 		no flags Details | Formatted Diff | Diff
Patch for landing (55.51 KB, patch)
2012-08-06 17:22 PDT, Adrienne Walker 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2012-08-06 16:31:55 PDT 
[chromium] Convert WebScrollbarThemeGeometry from a concrete class to an interface
Comment 1 Adrienne Walker 2012-08-06 16:39:19 PDT 
Created attachment 156790 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-06 16:42:03 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 James Robinson 2012-08-06 17:07:09 PDT 
Comment on attachment 156790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156790&action=review

> Source/WebCore/platform/chromium/support/WebScrollbarThemeGeometryNative.h:29
> +#include "ScrollbarThemeComposite.h"

mind moving this#include to the .cpp? You don't deref this type in any inline functions, so a forward decl would work here
Comment 4 Adrienne Walker 2012-08-06 17:22:04 PDT 
(In reply to comment #3)
> (From update of attachment 156790 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=156790&action=review
> 
> > Source/WebCore/platform/chromium/support/WebScrollbarThemeGeometryNative.h:29
> > +#include "ScrollbarThemeComposite.h"
> 
> mind moving this#include to the .cpp? You don't deref this type in any inline functions, so a forward decl would work here

Done.
Comment 5 Adrienne Walker 2012-08-06 17:22:12 PDT 
Created attachment 156807 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-08-06 20:00:26 PDT 
Comment on attachment 156807 [details]
Patch for landing

Clearing flags on attachment: 156807

Committed r124839: <http://trac.webkit.org/changeset/124839>
Comment 7 WebKit Review Bot 2012-08-06 20:00:31 PDT 
All reviewed patches have been landed.  Closing bug.