Bug 93308 – [chromium] Convert WebScrollbarThemeGeometry from a concrete class to an interface

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adrienne Walker]

[chromium] Convert WebScrollbarThemeGeometry from a concrete class to an interface

[Adrienne Walker]

Created attachment 156790 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[James Robinson]

Comment on attachment 156790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156790&action=review

> Source/WebCore/platform/chromium/support/WebScrollbarThemeGeometryNative.h:29
> +#include "ScrollbarThemeComposite.h"

mind moving this#include to the .cpp? You don't deref this type in any inline functions, so a forward decl would work here

[Adrienne Walker]

(In reply to comment #3)
> (From update of attachment 156790 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=156790&action=review
> 
> > Source/WebCore/platform/chromium/support/WebScrollbarThemeGeometryNative.h:29
> > +#include "ScrollbarThemeComposite.h"
> 
> mind moving this#include to the .cpp? You don't deref this type in any inline functions, so a forward decl would work here

Done.

[Adrienne Walker]

Created attachment 156807 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 156807 [details]
Patch for landing

Clearing flags on attachment: 156807

Committed r124839: <http://trac.webkit.org/changeset/124839>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.