Bug 93303 - Add the timestampOffset attribute to SourceBuffer
Summary: Add the timestampOffset attribute to SourceBuffer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anna Cavender
URL:
Keywords:
Depends on:
Blocks: 90819
  Show dependency treegraph
 
Reported: 2012-08-06 15:42 PDT by Anna Cavender
Modified: 2012-08-15 09:58 PDT (History)
11 users (show)

See Also:


Attachments
Patch (16.76 KB, patch)
2012-08-09 11:30 PDT, Anna Cavender
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-06 (390.69 KB, application/zip)
2012-08-09 13:33 PDT, WebKit Review Bot
no flags Details
fix typo and rerun tests (16.77 KB, patch)
2012-08-13 11:19 PDT, Anna Cavender
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anna Cavender 2012-08-06 15:42:48 PDT
On the 30 July 2012 version of the Media Source Extensions spec, a timestampOffset attribute was added to the SourceBuffer object:
http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html#dom-timestampoffset
Comment 1 Anna Cavender 2012-08-09 11:30:57 PDT
Created attachment 157496 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-09 11:33:16 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Anna Cavender 2012-08-09 13:27:22 PDT
Comment on attachment 157496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157496&action=review

> LayoutTests/http/tests/media/media-source/video-media-source-objects.html:49
> +                testExpected("segmentHelper.sourceBuffer.timestampOffset", 5);

There are some chromium changes that need to land before this test runs properly.  Otherwise, this patch is ready for review.
Comment 4 WebKit Review Bot 2012-08-09 13:33:49 PDT
Comment on attachment 157496 [details]
Patch

Attachment 157496 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13460655

New failing tests:
http/tests/media/media-source/video-media-source-objects.html
Comment 5 WebKit Review Bot 2012-08-09 13:33:54 PDT
Created attachment 157528 [details]
Archive of layout-test-results from gce-cr-linux-06

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 6 Eric Carlson 2012-08-09 14:44:39 PDT
Comment on attachment 157496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157496&action=review

The non-chromium change look OK to me. Not marking r+ because I am not  abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org.

> LayoutTests/http/tests/media/media-source/video-media-source-objects.html:77
> +                consoleWrite("Test that setting timestampOffset throws and error when the MediaSource is not associated with a media element.");

Nit: I think you want "throws an error"
Comment 7 Anna Cavender 2012-08-13 11:18:19 PDT
Comment on attachment 157496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157496&action=review

>> LayoutTests/http/tests/media/media-source/video-media-source-objects.html:49
>> +                testExpected("segmentHelper.sourceBuffer.timestampOffset", 5);
> 
> There are some chromium changes that need to land before this test runs properly.  Otherwise, this patch is ready for review.

These have landed and tests should run properly now.

>> LayoutTests/http/tests/media/media-source/video-media-source-objects.html:77
>> +                consoleWrite("Test that setting timestampOffset throws and error when the MediaSource is not associated with a media element.");
> 
> Nit: I think you want "throws an error"

Done.  Thanks!
Comment 8 Anna Cavender 2012-08-13 11:19:02 PDT
Created attachment 158052 [details]
fix typo and rerun tests
Comment 9 Anna Cavender 2012-08-15 09:58:34 PDT
Committed r125682: <http://trac.webkit.org/changeset/125682>