test-webkitpy hangs in a new checkout on snow leopard
Created attachment 156774 [details] Patch
Note that running test-webkitpy a second time seems to pass. Also note that this is a conservative patch; I didn't want to try and figure out what was hanging or why, as that seemed like it might be a fragile solution, and also more time-consuming than was really warranted.
Comment on attachment 156774 [details] Patch Confirmed that this fixes the problem at least on my Snow Leopard machine.
Comment on attachment 156774 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156774&action=review > Tools/Scripts/webkitpy/test/main.py:133 > + if installed_something: Should we restrict this to python older than 2.6.5?
(In reply to comment #4) > (From update of attachment 156774 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=156774&action=review > > > Tools/Scripts/webkitpy/test/main.py:133 > > + if installed_something: > > Should we restrict this to python older than 2.6.5? We could; I don't feel strongly about it, and this will only have an impact if we are actually autoinstalling things, which should only happen rarely.
(In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 156774 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=156774&action=review > > > > > Tools/Scripts/webkitpy/test/main.py:133 > > > + if installed_something: > > > > Should we restrict this to python older than 2.6.5? > > We could; I don't feel strongly about it, and this will only have an impact if we are actually autoinstalling things, which should only happen rarely. Would you like me to restrict it?
(In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > (From update of attachment 156774 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=156774&action=review > > > > > > > Tools/Scripts/webkitpy/test/main.py:133 > > > > + if installed_something: > > > > > > Should we restrict this to python older than 2.6.5? > > > > We could; I don't feel strongly about it, and this will only have an impact if we are actually autoinstalling things, which should only happen rarely. > > Would you like me to restrict it? It's up to you. I don't feel strongly. The main advantage of restricting IMO is that we can kill the code once we no longer support older pythons. Not a big deal in this case since it's a tiny amount of added complexity.
I'm not sure that adding an explicit version check gets you something that the fixme doesn't already get you; someone's still gonna have to grep for '2.6' or '2.6.1' and then do something. I'll leave it as it is for now since getting a useful python version string is mildly annoying :).
Committed r124928: <http://trac.webkit.org/changeset/124928>