Bug 93287 - Testcase LayoutTests/editing/input/editable-container-with-word-wrap-normal.html failing on Mac
Summary: Testcase LayoutTests/editing/input/editable-container-with-word-wrap-normal.h...
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.7
: P2 Normal
Assignee: Pravin D
Depends on:
Reported: 2012-08-06 11:48 PDT by Pravin D
Modified: 2012-08-06 16:02 PDT (History)
3 users (show)

See Also:

Patch (3.53 KB, text/plain)
2012-08-06 11:59 PDT, Pravin D
no flags Details
Patch (3.38 KB, text/plain)
2012-08-06 12:12 PDT, Pravin D
no flags Details
Patch (3.37 KB, patch)
2012-08-06 12:43 PDT, Pravin D
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pravin D 2012-08-06 11:48:08 PDT
Testcase LayoutTests/editing/input/editable-container-with-word-wrap-normal.html failing on Mac. The test uses 'End' key press emulation to scroll to the end of the text. However 'End' key press has a different behavior on mac as compared to Windows/Linux.
Comment 1 Pravin D 2012-08-06 11:59:23 PDT
Created attachment 156736 [details]
Comment 2 Ryosuke Niwa 2012-08-06 12:05:15 PDT
Comment on attachment 156736 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=156736&action=review

> LayoutTests/editing/input/editable-container-with-word-wrap-normal.html:39
> +    debug('NOTE:The testcase uses APIs exposed by window.internals and window.testRunner. The results will be incorrect when run in their absence.');

This is so verbose! Also, it's more helpful to tell the viewer how to test it manually. So I would revise that to something like "To manually test, move the caret to the end of the line."

> LayoutTests/editing/input/editable-container-with-word-wrap-normal.html:40
> +    debug('The content must scroll for the caret to reach the end of the editable text.');

Also, these two lines could be included in description() separated by \ns.
Comment 3 Pravin D 2012-08-06 12:12:30 PDT
Created attachment 156741 [details]
Comment 4 Ryosuke Niwa 2012-08-06 12:23:15 PDT
Comment on attachment 156741 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=156741&action=review

I don't think we need NOTE:.

> LayoutTests/editing/input/editable-container-with-word-wrap-normal.html:39
> +    debug('NOTE:To manually test, move the caret to the end of the line. \nThe content must scroll for the caret to reach the end of the editable text.');

Comment 5 Pravin D 2012-08-06 12:43:34 PDT
Created attachment 156747 [details]
Comment 6 WebKit Review Bot 2012-08-06 16:02:13 PDT
Comment on attachment 156747 [details]

Clearing flags on attachment: 156747

Committed r124806: <http://trac.webkit.org/changeset/124806>
Comment 7 WebKit Review Bot 2012-08-06 16:02:16 PDT
All reviewed patches have been landed.  Closing bug.