Bug 93287 – Testcase LayoutTests/editing/input/editable-container-with-word-wrap-normal.html failing on Mac

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Pravin D]

Testcase LayoutTests/editing/input/editable-container-with-word-wrap-normal.html failing on Mac. The test uses 'End' key press emulation to scroll to the end of the text. However 'End' key press has a different behavior on mac as compared to Windows/Linux.

[Pravin D]

Created attachment 156736 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 156736 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156736&action=review

> LayoutTests/editing/input/editable-container-with-word-wrap-normal.html:39
> +    debug('NOTE:The testcase uses APIs exposed by window.internals and window.testRunner. The results will be incorrect when run in their absence.');

This is so verbose! Also, it's more helpful to tell the viewer how to test it manually. So I would revise that to something like "To manually test, move the caret to the end of the line."

> LayoutTests/editing/input/editable-container-with-word-wrap-normal.html:40
> +    debug('The content must scroll for the caret to reach the end of the editable text.');

Also, these two lines could be included in description() separated by \ns.

[Pravin D]

Created attachment 156741 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 156741 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156741&action=review

I don't think we need NOTE:.

> LayoutTests/editing/input/editable-container-with-word-wrap-normal.html:39
> +    debug('NOTE:To manually test, move the caret to the end of the line. \nThe content must scroll for the caret to reach the end of the editable text.');

I

[Pravin D]

Created attachment 156747 [details]
Patch

[WebKit Review Bot]

Comment on attachment 156747 [details]
Patch

Clearing flags on attachment: 156747

Committed r124806: <http://trac.webkit.org/changeset/124806>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.