[chromium] Add support to DumpRenderTree [EventSender] for GestureTapDown events.
Created attachment 156732 [details] Patch
Comment on attachment 156732 [details] Patch looks reasonable to me.
I was thinking it might be useful be able to pass an additional piece of information in GestureTapDown, namely to use deltaX (or some additional field) to signal that a DRT test is in progress - this would simplify handling pixel tests for the link highlighter (which normally will be changing opacity in an unsynchronized way ...). Normally GestureTapDown would ignore deltaX. Is this reasonable? Or should we create a new field in the gesture event object?
I don't think that plumbing data through is necessary (or a good pattern to follow) - we have layoutTestMode, and generally speaking our test code should use as much of the same logic as our production code.
Comment on attachment 156732 [details] Patch R=me
(In reply to comment #4) > I don't think that plumbing data through is necessary (or a good pattern to follow) - we have layoutTestMode, and generally speaking our test code should use as much of the same logic as our production code. Looks like layoutTestMode() is just what the doctor ordered, so we're good!
Comment on attachment 156732 [details] Patch Clearing flags on attachment: 156732 Committed r124906: <http://trac.webkit.org/changeset/124906>
All reviewed patches have been landed. Closing bug.