RESOLVED FIXED 93286
[chromium] Add support to DumpRenderTree [EventSender] for GestureTapDown events. 
https://bugs.webkit.org/show_bug.cgi?id=93286
Summary [chromium] Add support to DumpRenderTree [EventSender] for GestureTapDown eve...
W. James MacLean
Reported 2012-08-06 11:38:58 PDT
[chromium] Add support to DumpRenderTree [EventSender] for GestureTapDown events.
Attachments
Patch (5.95 KB, patch)
2012-08-06 11:43 PDT, W. James MacLean 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
W. James MacLean
Comment 1 2012-08-06 11:43:17 PDT
Created attachment 156732 [details] Patch
Robert Kroeger
Comment 2 2012-08-07 07:55:15 PDT
Comment on attachment 156732 [details] Patch looks reasonable to me.
W. James MacLean
Comment 3 2012-08-07 08:37:35 PDT
I was thinking it might be useful be able to pass an additional piece of information in GestureTapDown, namely to use deltaX (or some additional field) to signal that a DRT test is in progress - this would simplify handling pixel tests for the link highlighter (which normally will be changing opacity in an unsynchronized way ...). Normally GestureTapDown would ignore deltaX. Is this reasonable? Or should we create a new field in the gesture event object?
James Robinson
Comment 4 2012-08-07 11:17:18 PDT
I don't think that plumbing data through is necessary (or a good pattern to follow) - we have layoutTestMode, and generally speaking our test code should use as much of the same logic as our production code.
James Robinson
Comment 5 2012-08-07 11:18:02 PDT
Comment on attachment 156732 [details] Patch R=me
W. James MacLean
Comment 6 2012-08-07 12:19:42 PDT
(In reply to comment #4) > I don't think that plumbing data through is necessary (or a good pattern to follow) - we have layoutTestMode, and generally speaking our test code should use as much of the same logic as our production code. Looks like layoutTestMode() is just what the doctor ordered, so we're good!
WebKit Review Bot
Comment 7 2012-08-07 12:26:11 PDT
Comment on attachment 156732 [details] Patch Clearing flags on attachment: 156732 Committed r124906: <http://trac.webkit.org/changeset/124906>
WebKit Review Bot
Comment 8 2012-08-07 12:26:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.