Bug 93281 - [EFL] Enable link prefetch
Summary: [EFL] Enable link prefetch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-06 10:56 PDT by Gyuyoung Kim
Modified: 2012-08-06 23:37 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.91 KB, patch)
2012-08-06 10:59 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (5.00 KB, patch)
2012-08-06 17:31 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-08-06 10:56:10 PDT
It seems to me EFL port can enable LINK_PREFETCH feature because this feature doesn't have port dependency. So, this patch enables this feature. In addition, this patch unskipes test cases in TestExpectation file except for a test case(fast/dom/HTMLLinkElement/subresource.html). This test case is going to be unskipped soon.
Comment 1 Gyuyoung Kim 2012-08-06 10:59:02 PDT
Created attachment 156724 [details]
Patch
Comment 2 Chris Dumez 2012-08-06 11:02:43 PDT
Comment on attachment 156724 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156724&action=review

> LayoutTests/platform/efl/TestExpectations:63
>  // Link prefetch is disabled by default

This comment is outdated.

> LayoutTests/platform/efl/TestExpectations:64
>  BUGWKEFL SKIP : fast/dom/HTMLLinkElement/subresource.html = PASS

Why can't you unskip this test? You need to update the comment.
Comment 3 Gyuyoung Kim 2012-08-06 17:31:17 PDT
Created attachment 156809 [details]
Patch
Comment 4 Gyuyoung Kim 2012-08-06 17:31:47 PDT
Patch is updated.
Comment 5 Chris Dumez 2012-08-06 23:09:56 PDT
Comment on attachment 156809 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156809&action=review

> LayoutTests/platform/efl/TestExpectations:64
>  BUGWKEFL SKIP : fast/dom/HTMLLinkElement/subresource.html = PASS

The patch looks good to me. But, out of curiosity, could you tell me what's the diff for this remaining test? MIME type differences are sometimes normal and we often use platform-specific expectations for those.
Comment 6 Kentaro Hara 2012-08-06 23:10:12 PDT
Comment on attachment 156809 [details]
Patch

Looks OK
Comment 7 Gyuyoung Kim 2012-08-06 23:13:22 PDT
(In reply to comment #5)
> (From update of attachment 156809 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=156809&action=review
> 
> > LayoutTests/platform/efl/TestExpectations:64
> >  BUGWKEFL SKIP : fast/dom/HTMLLinkElement/subresource.html = PASS
> 
> The patch looks good to me. But, out of curiosity, could you tell me what's the diff for this remaining test? MIME type differences are sometimes normal and we often use platform-specific expectations for those.

MIME type result is different from expected result as below, 

- prefetch.link has MIME type application/octet-stream
+ prefetch.link has MIME type text/plain

Almost ports also skipped this test. So, I think this test case needs to be unskipped in new bug.
Comment 8 Gyuyoung Kim 2012-08-06 23:14:12 PDT
Comment on attachment 156809 [details]
Patch

I will file a bug for fast/dom/HTMLLinkElement/subresource.html soon.
Comment 9 WebKit Review Bot 2012-08-06 23:37:25 PDT
Comment on attachment 156809 [details]
Patch

Clearing flags on attachment: 156809

Committed r124856: <http://trac.webkit.org/changeset/124856>
Comment 10 WebKit Review Bot 2012-08-06 23:37:30 PDT
All reviewed patches have been landed.  Closing bug.