RESOLVED FIXED 93281
[EFL] Enable link prefetch 
https://bugs.webkit.org/show_bug.cgi?id=93281
Summary [EFL] Enable link prefetch
Gyuyoung Kim
Reported 2012-08-06 10:56:10 PDT
It seems to me EFL port can enable LINK_PREFETCH feature because this feature doesn't have port dependency. So, this patch enables this feature. In addition, this patch unskipes test cases in TestExpectation file except for a test case(fast/dom/HTMLLinkElement/subresource.html). This test case is going to be unskipped soon.
Attachments
Patch (4.91 KB, patch)
2012-08-06 10:59 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (5.00 KB, patch)
2012-08-06 17:31 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-08-06 10:59:02 PDT
Created attachment 156724 [details] Patch
Chris Dumez
Comment 2 2012-08-06 11:02:43 PDT
Comment on attachment 156724 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156724&action=review > LayoutTests/platform/efl/TestExpectations:63 > // Link prefetch is disabled by default This comment is outdated. > LayoutTests/platform/efl/TestExpectations:64 > BUGWKEFL SKIP : fast/dom/HTMLLinkElement/subresource.html = PASS Why can't you unskip this test? You need to update the comment.
Gyuyoung Kim
Comment 3 2012-08-06 17:31:17 PDT
Created attachment 156809 [details] Patch
Gyuyoung Kim
Comment 4 2012-08-06 17:31:47 PDT
Patch is updated.
Chris Dumez
Comment 5 2012-08-06 23:09:56 PDT
Comment on attachment 156809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156809&action=review > LayoutTests/platform/efl/TestExpectations:64 > BUGWKEFL SKIP : fast/dom/HTMLLinkElement/subresource.html = PASS The patch looks good to me. But, out of curiosity, could you tell me what's the diff for this remaining test? MIME type differences are sometimes normal and we often use platform-specific expectations for those.
Kentaro Hara
Comment 6 2012-08-06 23:10:12 PDT
Comment on attachment 156809 [details] Patch Looks OK
Gyuyoung Kim
Comment 7 2012-08-06 23:13:22 PDT
(In reply to comment #5) > (From update of attachment 156809 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=156809&action=review > > > LayoutTests/platform/efl/TestExpectations:64 > > BUGWKEFL SKIP : fast/dom/HTMLLinkElement/subresource.html = PASS > > The patch looks good to me. But, out of curiosity, could you tell me what's the diff for this remaining test? MIME type differences are sometimes normal and we often use platform-specific expectations for those. MIME type result is different from expected result as below, - prefetch.link has MIME type application/octet-stream + prefetch.link has MIME type text/plain Almost ports also skipped this test. So, I think this test case needs to be unskipped in new bug.
Gyuyoung Kim
Comment 8 2012-08-06 23:14:12 PDT
Comment on attachment 156809 [details] Patch I will file a bug for fast/dom/HTMLLinkElement/subresource.html soon.
WebKit Review Bot
Comment 9 2012-08-06 23:37:25 PDT
Comment on attachment 156809 [details] Patch Clearing flags on attachment: 156809 Committed r124856: <http://trac.webkit.org/changeset/124856>
WebKit Review Bot
Comment 10 2012-08-06 23:37:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.