Bug 93274 - IndexedDB: Remove IDBRequest::finishCursor() and plumbing
Summary: IndexedDB: Remove IDBRequest::finishCursor() and plumbing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-06 09:12 PDT by Joshua Bell
Modified: 2012-08-06 20:40 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.34 KB, patch)
2012-08-06 10:13 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-08-06 09:12:08 PDT
https://bugs.webkit.org/show_bug.cgi?id=86911 made the m_cursorFinished state in IDBRequest obsolete but it and the plumbing to set it via IDBRequest::finishCursor() was not removed.

Delete it!
Comment 1 Joshua Bell 2012-08-06 10:13:26 PDT
Created attachment 156719 [details]
Patch
Comment 2 Joshua Bell 2012-08-06 10:14:08 PDT
Trivial cleanup.

tony@ - r? cq?
Comment 3 WebKit Review Bot 2012-08-06 19:02:38 PDT
Comment on attachment 156719 [details]
Patch

Rejecting attachment 156719 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
-continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 9
g run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/13450290
Comment 4 WebKit Review Bot 2012-08-06 20:40:46 PDT
Comment on attachment 156719 [details]
Patch

Clearing flags on attachment: 156719

Committed r124842: <http://trac.webkit.org/changeset/124842>
Comment 5 WebKit Review Bot 2012-08-06 20:40:49 PDT
All reviewed patches have been landed.  Closing bug.