Bug 93265 - Web Inspector: make the MemoryClassInfo class a not-template
Summary: Web Inspector: make the MemoryClassInfo class a not-template
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexei Filippov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-06 06:36 PDT by Alexei Filippov
Modified: 2012-08-07 06:51 PDT (History)
21 users (show)

See Also:


Attachments
Patch (63.95 KB, patch)
2012-08-06 06:39 PDT, Alexei Filippov
no flags Details | Formatted Diff | Diff
Patch (94.78 KB, patch)
2012-08-06 07:21 PDT, Alexei Filippov
no flags Details | Formatted Diff | Diff
Patch (98.51 KB, patch)
2012-08-06 09:13 PDT, Alexei Filippov
no flags Details | Formatted Diff | Diff
Patch (95.16 KB, patch)
2012-08-07 03:28 PDT, Alexei Filippov
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cq-03 (585.06 KB, application/zip)
2012-08-07 05:43 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexei Filippov 2012-08-06 06:36:45 PDT
EOM
Comment 1 Alexei Filippov 2012-08-06 06:39:48 PDT
Created attachment 156682 [details]
Patch
Comment 2 Alexei Filippov 2012-08-06 07:21:22 PDT
Created attachment 156689 [details]
Patch
Comment 3 Alexei Filippov 2012-08-06 07:21:59 PDT
Rebaselined.
Comment 4 Yury Semikhatsky 2012-08-06 07:49:39 PDT
Comment on attachment 156689 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156689&action=review

> Source/WebCore/dom/MemoryInstrumentation.h:182
> +    MemoryClassInfo(MemoryObjectInfo* memoryObjectInfo, MemoryInstrumentation::ObjectType objectType)

I would thing that the ptr is used for checking if the object has already been visited before processing it. Now we only check if an object has already been processed right before adding it to the queue of deferred pointers. But the object may be already visited by the moment the deferred pointer gets processed and we probably need to add a check for the pointer.
Comment 5 WebKit Review Bot 2012-08-06 08:06:49 PDT
Comment on attachment 156689 [details]
Patch

Attachment 156689 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13447307
Comment 6 Yury Semikhatsky 2012-08-06 08:10:42 PDT
Comment on attachment 156689 [details]
Patch

One advantage of having "this" parameter is that the compiler will check that MemoryClassInfo template parameter is the same as the type of "this".
Comment 7 Alexei Filippov 2012-08-06 09:13:37 PDT
Created attachment 156702 [details]
Patch
Comment 8 Alexei Filippov 2012-08-06 09:16:04 PDT
(In reply to comment #6)
> (From update of attachment 156689 [details])
> One advantage of having "this" parameter is that the compiler will check that MemoryClassInfo template parameter is the same as the type of "this".

Ok. I made it vice versa. You don't need to explicitly specify the class. It is now deduced from the 'this' pointer.
Comment 9 Ilya Tikhonovsky 2012-08-06 10:55:55 PDT
Comment on attachment 156702 [details]
Patch

strange changes of files' mode. otherwise looks good
Comment 10 Build Bot 2012-08-06 15:07:18 PDT
Comment on attachment 156702 [details]
Patch

Attachment 156702 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13450130
Comment 11 Yury Semikhatsky 2012-08-07 00:20:05 PDT
Comment on attachment 156702 [details]
Patch

Please revert file mode changes, otherwise looks good.
Comment 12 Alexei Filippov 2012-08-07 03:28:13 PDT
Created attachment 156904 [details]
Patch
Comment 13 Alexei Filippov 2012-08-07 03:29:27 PDT
(In reply to comment #11)
> (From update of attachment 156702 [details])
> Please revert file mode changes, otherwise looks good.

done
+rebaselining
Comment 14 WebKit Review Bot 2012-08-07 05:43:21 PDT
Comment on attachment 156904 [details]
Patch

Rejecting attachment 156904 [details] from commit-queue.

New failing tests:
fast/speech/input-appearance-searchandspeech.html
Full output: http://queues.webkit.org/results/13449449
Comment 15 WebKit Review Bot 2012-08-07 05:43:28 PDT
Created attachment 156919 [details]
Archive of layout-test-results from gce-cq-03

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: gce-cq-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 16 WebKit Review Bot 2012-08-07 06:51:11 PDT
Comment on attachment 156904 [details]
Patch

Clearing flags on attachment: 156904

Committed r124884: <http://trac.webkit.org/changeset/124884>
Comment 17 WebKit Review Bot 2012-08-07 06:51:18 PDT
All reviewed patches have been landed.  Closing bug.