As you can see from Carlos's last comment on bug 90268 [1], it seems like I was too fast pushing that patch and that some improvements could still have happened over the last iteration of the patch. So, this bug is just for tracking down those improvements, now that bug 90268 has already been resolved. [1] https://bugs.webkit.org/show_bug.cgi?id=90268#c25
Created attachment 156680 [details] Patch proposal Patch addressing the issues pointed out by Carlos in https://bugs.webkit.org/show_bug.cgi?id=90268#c25
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment on attachment 156680 [details] Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=156680&action=review Please, check the comments I made here before landing, thanks! > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:485 > + if (!spellCheckingLanguages.length()) Use spellCheckingLanguages.isNull() instead. > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:517 > + context->priv->textChecker->setSpellCheckingLanguages(CString(languages)); A char* can be assigned to a CString, so I'm not sure, but I think you can pass the languages directly here: context->priv->textChecker->setSpellCheckingLanguages(languages);
Committed r124763: <http://trac.webkit.org/changeset/124763>