Bug 93250 – watchlist related bug revealed by r124728

• Status: NEW
• Component: New Bugs

[Csaba Osztrogonác]

t.watchlistloader_unittest.WatchListLoaderTest.test_watch_list_load failed:
  Traceback (most recent call last):
    File "/home/oszi/WebKit/Tools/Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py", line 45, in test_watch_list_load
      OutputCapture().assert_outputs(self, WatchListLoader(filesystem.FileSystem()).load, expected_logs="")
    File "/home/oszi/WebKit/Tools/Scripts/webkitpy/common/system/outputcapture.py", line 100, in assert_outputs
      testcase.assertEqual(logs_string, expected_logs)
  AssertionError: 'The email alias [e-mail] which is in the watchlist is not listed as a contributor in committers.py\nThe email alias [e-mail] which is in the watchlist is not listed as a contributor in committers.py\nThe email alias [e-mail] which is in the watchlist is not listed as a contributor in committers.py\nThe email alias [e-mail] which is in the watchlist is not listed as a contributor in committers.py\nThe email alias [e-mail] which is in the watchlist is not listed as a contributor in committers.py\nThe email alias [e-mail] which is in the watchlist is not listed as a contributor in committers.py\n' != ''

But [e-mail] is committer in Tools/Scripts/webkitpy/common/config/committers.py.
I tried to change to order of Gyuyoung's mail addresses in committers.py and all tests pass:
-    Committer("Gyuyoung Kim", ["[e-mail]", "[e-mail]"], "gyuyoung"),
+    Committer("Gyuyoung Kim", ["[e-mail]", "[e-mail]"], "gyuyoung"),

It seems it is a bug somewhere in watchlist code.

[Peter Gal]

This is because only the first email address is used as a bugzilla address in the CommiterList and the watchlist uses the bugzilla addresses. Maybe we should use all addresses for this case.

[Peter Gal]

(In reply to comment #1)
> This is because only the first email address is used as a bugzilla address in the CommiterList and the watchlist uses the bugzilla addresses. Maybe we should use all addresses for this case.

Okay... scratch that. I misunderstood the watchlist a little bit. So to correct myself: maybe we should explicitly specify that which address is the bugzilla address to resolve this kind of issues.