Handle variables in CSSParser::parseValidPrimitive(), preventing null return value.
Created attachment 156623 [details]
Comment on attachment 156623 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=156623&action=review
> + if (value->unit == CSSPrimitiveValue::CSS_VARIABLE_NAME)
Why are variables a unit type? I think I need to study how variables are implemented a bit before I'm qualified to review this. dglazkov can probably review this before I get to it tomorrow.
> +if (window.testRunner)
Nit: We normally include the <!DOCTYPE html> and <html> tag for new tests unless you're intentionally testing quirks mode.
Created attachment 156792 [details]
Comment on attachment 156792 [details]
Clearing flags on attachment: 156792
Committed r124833: <http://trac.webkit.org/changeset/124833>
All reviewed patches have been landed. Closing bug.