RESOLVED FIXED 93235
Handle variables in CSSParser::parseValidPrimitive(), preventing null return value. 
https://bugs.webkit.org/show_bug.cgi?id=93235
Summary Handle variables in CSSParser::parseValidPrimitive(), preventing null return ...
Luke Macpherson
Reported 2012-08-06 01:40:20 PDT
Handle variables in CSSParser::parseValidPrimitive(), preventing null return value.
Attachments
Patch (3.68 KB, patch)
2012-08-06 01:43 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Patch (3.72 KB, patch)
2012-08-06 16:40 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2012-08-06 01:43:31 PDT
Created attachment 156623 [details] Patch
Tony Chang
Comment 2 2012-08-06 02:21:33 PDT
Comment on attachment 156623 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156623&action=review > Source/WebCore/css/CSSParser.cpp:1642 > + if (value->unit == CSSPrimitiveValue::CSS_VARIABLE_NAME) Why are variables a unit type? I think I need to study how variables are implemented a bit before I'm qualified to review this. dglazkov can probably review this before I get to it tomorrow. > LayoutTests/fast/css/variables/invalid-font-reference.html:2 > +<script> > +if (window.testRunner) Nit: We normally include the <!DOCTYPE html> and <html> tag for new tests unless you're intentionally testing quirks mode.
Luke Macpherson
Comment 3 2012-08-06 16:40:46 PDT
Created attachment 156792 [details] Patch
WebKit Review Bot
Comment 4 2012-08-06 18:57:43 PDT
Comment on attachment 156792 [details] Patch Clearing flags on attachment: 156792 Committed r124833: <http://trac.webkit.org/changeset/124833>
WebKit Review Bot
Comment 5 2012-08-06 18:57:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.