WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
93207
LayoutTest: fast/forms/validation-message-user-modify.html fails (adding to skiplist platform/win/Skipped)
https://bugs.webkit.org/show_bug.cgi?id=93207
Summary
LayoutTest: fast/forms/validation-message-user-modify.html fails (adding to s...
Roger Fong
Reported
2012-08-05 14:12:09 PDT
The 'required' property for forms has not yet been implemented. This test should not be run and was not added to the Windows skip list.
Attachments
Adding test to skip list
(1.39 KB, patch)
2012-08-05 14:35 PDT
,
Roger Fong
no flags
Details
Formatted Diff
Diff
Adjust patch comments
(1.33 KB, patch)
2012-08-06 15:47 PDT
,
Roger Fong
no flags
Details
Formatted Diff
Diff
More comment changes
(1.30 KB, patch)
2012-08-06 16:39 PDT
,
Roger Fong
no flags
Details
Formatted Diff
Diff
style corrections
(1.30 KB, patch)
2012-08-06 17:03 PDT
,
Roger Fong
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2012-08-05 14:12:55 PDT
Is there a bug tracking this work?
Roger Fong
Comment 2
2012-08-05 14:14:15 PDT
(In reply to
comment #0
)
> The 'required' property for forms has not yet been implemented. > This test should not be run and was not added to the Windows skip list.
See <
rdar://problem/11965018
> for associated enhancement bug.
Tim Horton
Comment 3
2012-08-05 14:15:14 PDT
(In reply to
comment #2
)
> (In reply to
comment #0
) > > The 'required' property for forms has not yet been implemented. > > This test should not be run and was not added to the Windows skip list. > > See <
rdar://problem/11965018
> for associated enhancement bug.
There ought to be a bugzilla bug. And I wonder why there's a test if it's not implemented?
Roger Fong
Comment 4
2012-08-05 14:19:05 PDT
O and yes this test uses the required property to force a validation window to pop up, and then tests the bubble to make sure that it is read only. Since the required property is not implemented though, the test fails. Perhaps we should just create a new test case that does work with this with some javascripting. (Or wait for just wait for the feature to be implemented and then remove this test from the skip list)
Roger Fong
Comment 5
2012-08-05 14:19:54 PDT
I'll create a bugzilla bug to associate with the radar.
Tim Horton
Comment 6
2012-08-05 14:20:04 PDT
It looks to me like it's expected to be implemented:
https://bugs.webkit.org/show_bug.cgi?id=25551
Roger Fong
Comment 7
2012-08-05 14:22:18 PDT
Ah looks like it. I'll associate the radar with that one.
Roger Fong
Comment 8
2012-08-05 14:24:03 PDT
So should I bother adding the test to the skip list then if it's expected? I guess one could say 'for the sake of making the bots greener' ... not that that means much.
Tim Horton
Comment 9
2012-08-05 14:24:59 PDT
(In reply to
comment #8
)
> So should I bother adding the test to the skip list then if it's expected? I guess one could say 'for the sake of making the bots greener' ... not that that means much.
I think you should! And you should remove the "required property not yet implemented" bit from this bugs title, and Cc the authors of the test and maybe the people who implemented "required", etc.
Roger Fong
Comment 10
2012-08-05 14:35:22 PDT
Created
attachment 156569
[details]
Adding test to skip list
Roger Fong
Comment 11
2012-08-06 12:00:51 PDT
Correction: The required attribute is now broken. Was working after
https://bugs.webkit.org/show_bug.cgi?id=25551
but has since regressed. Temporarily adding test to skip list and filing new bug for regression.
Roger Fong
Comment 12
2012-08-06 15:38:49 PDT
(In reply to
comment #11
)
> Correction: The required attribute is now broken. > Was working after
https://bugs.webkit.org/show_bug.cgi?id=25551
> but has since regressed. Temporarily adding test to skip list and filing new bug for regression.
Correction to correction: I have no idea if it ever worked on safari. Things to note: -Mac: test passes because if the validation bubble doesn't appear, then the test tries to modify nothing, which makes the before and after states of the page the same, causing the test to pass -Windows: internals reference does not exist, seems to be problems with Windows testing infrastructure -In general: If anyone knows whether or not this ever worked in Safari let me know. There seems to be minor evidence that it did to some extent from what I've found online but nothing conclusive. If it did, I'll file a regression bug, if not I'll just file a bug bug. For now the test is just being slapped on the skip list on Windows to help with the green-liness.
Roger Fong
Comment 13
2012-08-06 15:47:40 PDT
Created
attachment 156778
[details]
Adjust patch comments
Roger Fong
Comment 14
2012-08-06 16:34:51 PDT
This feature has never worked in safari, the hooks are there but the browser does not use them yet. Thanks Jon
Roger Fong
Comment 15
2012-08-06 16:39:42 PDT
Created
attachment 156791
[details]
More comment changes
Roger Fong
Comment 16
2012-08-06 17:03:28 PDT
Created
attachment 156804
[details]
style corrections
WebKit Review Bot
Comment 17
2012-08-06 18:45:36 PDT
Comment on
attachment 156804
[details]
style corrections Clearing flags on attachment: 156804 Committed
r124831
: <
http://trac.webkit.org/changeset/124831
>
WebKit Review Bot
Comment 18
2012-08-06 18:45:41 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug