RESOLVED FIXED 93206
[Qt] Compile errors with OpenGLES2 
https://bugs.webkit.org/show_bug.cgi?id=93206
Summary [Qt] Compile errors with OpenGLES2
Loïc Yhuel
Reported 2012-08-05 13:10:42 PDT
I'm building QtWebKit with Qt5 and OpenGLES2. There are two build errors : 1) In file included from /home/loic/src/webkit/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:41:0: /home/loic/src/webkit/Source/WebCore/platform/graphics/OpenGLESShims.h:57:0: error: "GL_MAX_SAMPLES_EXT" redefined [-Werror] In file included from /home/loic/src/webkit/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h:33:0, from /home/loic/src/webkit/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:34: /home/loic/src/webkit/Source/ThirdParty/ANGLE/include/GLES2/gl2ext.h:335:0: note: this is the location of the previous definition 2) In file included from /home/loic/src/webkit/Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:31:0: /usr/include/GL/glext.h:7557:81: error: ‘GLclampd’ does not name a type /usr/include/GL/glext.h:7558:61: error: ‘GLclampd’ has not been declared /usr/include/GL/glext.h:7558:73: error: ‘GLclampd’ has not been declared ...
Attachments
Patch (2.57 KB, patch)
2012-08-08 07:53 PDT, Loïc Yhuel 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Loïc Yhuel
Comment 1 2012-08-05 13:21:09 PDT
First error is due to a define added in r122586 : - in Source/WebCore/platform/Graphics/OpenGLESShims.h : #define GL_MAX_SAMPLES_EXT 0x8D57 - in Source/ThirdParty/ANGLE/include/GLES2/gl2ext.h : #define GL_MAX_SAMPLES_EXT 0x9135 Should the OpenGLESShims.h value be used only for Blackberry ? For the second error, GLX should only be used with OpenGL, we could modify features.prf : haveQt(5):linux-*:config_glx:!contains(QT_CONFIG, opengles2): DEFINES += HAVE_GLX=1
Loïc Yhuel
Comment 2 2012-08-05 16:56:29 PDT
I wonder why GL_MAX_SAMPLES_EXT is in OpenGLESShims.h, as it's only used in GraphicsContext3DOpenGL.cpp, which is not used in OpenGLES2 configuration of QtWebKit and in Blackberry port.
Loïc Yhuel
Comment 3 2012-08-08 07:53:36 PDT
Created attachment 157218 [details] Patch
WebKit Review Bot
Comment 4 2012-08-08 08:42:47 PDT
Comment on attachment 157218 [details] Patch Clearing flags on attachment: 157218 Committed r125039: <http://trac.webkit.org/changeset/125039>
WebKit Review Bot
Comment 5 2012-08-08 08:42:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.