Bug 93205 - Refactor console logging out of CSPDirectiveList into ContentSecurityPolicy
Summary: Refactor console logging out of CSPDirectiveList into ContentSecurityPolicy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike West
URL:
Keywords:
Depends on:
Blocks: 93197
  Show dependency tree / graph
 
Reported: 2012-08-05 12:12 PDT by Mike West
Modified: 2012-08-08 04:57 PDT (History)
2 users (show)

See Also:

Attachments
Patch (24.21 KB, patch)
2012-08-06 01:45 PDT, Mike West 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike West 2012-08-05 12:12:36 PDT 
Currently, CSPDirectiveList is the only piece of ContentSecurityPolicy's architecture that can log to the console. I think we can improve the situation by extracting the logging functions and moving them to the policy object, and then teaching each of the lower-level objects about the policy in which they live.
Comment 1 Mike West 2012-08-06 01:45:08 PDT 
Created attachment 156624 [details]
Patch
Comment 2 Mike West 2012-08-06 01:47:18 PDT 
Hey Adam, this is a pass at the refactoring I asked you about over the weekend. In a nut, it replaces the dependence on ScriptExecutionContext with a dependence on ContentSecurityPolicy, adding a few new methods to CSP in order to route a few of the context-relevant requests through the policy object.

Not high priority, so just take a look whenever you have a chance. :)  Thanks!
Comment 3 Adam Barth 2012-08-07 15:26:33 PDT 
Thanks.
Comment 4 Mike West 2012-08-08 01:27:16 PDT 
Comment on attachment 156624 [details]
Patch

Danke! CQ?
Comment 5 WebKit Review Bot 2012-08-08 04:57:00 PDT 
Comment on attachment 156624 [details]
Patch

Clearing flags on attachment: 156624

Committed r125021: <http://trac.webkit.org/changeset/125021>
Comment 6 WebKit Review Bot 2012-08-08 04:57:04 PDT 
All reviewed patches have been landed.  Closing bug.