Bug 93189 – [CMake] Add the ENSURE_MINIMUM_PACKAGE_VERSION macro.

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Tools / Tests

[Raphael Kubo da Costa (:rakuco)]

[CMake] Add the ENSURE_MINIMUM_PACKAGE_VERSION macro.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 156544 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

CC'ing a few CMake-interested people.

[Patrick R. Gansterer]

Comment on attachment 156544 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156544&action=review

> Source/cmake/WebKitMacros.cmake:265
> +# FIXME: This macro can be removed once we start depending on CMake 2.8.3, as we can use

which CMake version do you use?!?!? 2.8.2 is very old...

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 156544 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156544&action=review

>> Source/cmake/WebKitMacros.cmake:265
>> +# FIXME: This macro can be removed once we start depending on CMake 2.8.3, as we can use
> 
> which CMake version do you use?!?!? 2.8.2 is very old...

As I mentioned in <https://bugs.webkit.org/show_bug.cgi?id=93191#c5>, the problem is not the version I use, but the minimum one we require in the top-level CMakeLists.txt.

[Patrick R. Gansterer]

(In reply to comment #4)
> (From update of attachment 156544 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=156544&action=review
> 
> >> Source/cmake/WebKitMacros.cmake:265
> >> +# FIXME: This macro can be removed once we start depending on CMake 2.8.3, as we can use
> > 
> > which CMake version do you use?!?!? 2.8.2 is very old...
> 
> As I mentioned in <https://bugs.webkit.org/show_bug.cgi?id=93191#c5>, the problem is not the version I use, but the minimum one we require in the top-level CMakeLists.txt.

Lets bump the version. I don't see much value in supporting such old CMake versions.

[Thiago Marcos P. Santos]

Comment on attachment 156544 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156544&action=review

>>>> Source/cmake/WebKitMacros.cmake:265
>>>> +# FIXME: This macro can be removed once we start depending on CMake 2.8.3, as we can use
>>> 
>>> which CMake version do you use?!?!? 2.8.2 is very old...
>> 
>> As I mentioned in <https://bugs.webkit.org/show_bug.cgi?id=93191#c5>, the problem is not the version I use, but the minimum one we require in the top-level CMakeLists.txt.
> 
> Lets bump the version. I don't see much value in supporting such old CMake versions.

+1 for bumping.

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #5)
> Lets bump the version. I don't see much value in supporting such old CMake versions.

I'm OK with that, but I'd like to hear from Ming (already CC'ed) or anyone else from the BlackBerry team (I've CC'ed tonikitoo and Rob) first, as we need to know if they have any requirement to support CMake < 2.8.3.

[Ming Xie]

(In reply to comment #7)
> (In reply to comment #5)
> > Lets bump the version. I don't see much value in supporting such old CMake versions.
> 
> I'm OK with that, but I'd like to hear from Ming (already CC'ed) or anyone else from the BlackBerry team (I've CC'ed tonikitoo and Rob) first, as we need to know if they have any requirement to support CMake < 2.8.3.

Currently our build machines still use 2.8.0. However, I don't want our BlackBerry port blocks this upgrade if 2.8.3 brings new features to the project.

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #5)
> > > Lets bump the version. I don't see much value in supporting such old CMake versions.
> > 
> > I'm OK with that, but I'd like to hear from Ming (already CC'ed) or anyone else from the BlackBerry team (I've CC'ed tonikitoo and Rob) first, as we need to know if they have any requirement to support CMake < 2.8.3.
> 
> Currently our build machines still use 2.8.0. However, I don't want our BlackBerry port blocks this upgrade if 2.8.3 brings new features to the project.

Thank you for the response. I'll cook a new patch to bump our requirements then.

[Gyuyoung Kim]

(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #5)
> > > Lets bump the version. I don't see much value in supporting such old CMake versions.
> > 
> > I'm OK with that, but I'd like to hear from Ming (already CC'ed) or anyone else from the BlackBerry team (I've CC'ed tonikitoo and Rob) first, as we need to know if they have any requirement to support CMake < 2.8.3.
> 
> Currently our build machines still use 2.8.0. However, I don't want our BlackBerry port blocks this upgrade if 2.8.3 brings new features to the project.

As I mentioned in webkit-efl mailing list, it looks Tizen is using CMake 2.8.5. But, I also don't want to block to land this upgrade.

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #9)
> Thank you for the response. I'll cook a new patch to bump our requirements then.

I have now filed bug 93450.

[Raphael Kubo da Costa (:rakuco)]

Closing now that we require CMake 2.8.3 since <http://trac.webkit.org/changeset/125228>.