WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
93165
[chromium] Add gyp variable to control which compositor target is depended on
https://bugs.webkit.org/show_bug.cgi?id=93165
Summary
[chromium] Add gyp variable to control which compositor target is depended on
James Robinson
Reported
2012-08-03 16:06:15 PDT
[chromium] Add gyp variable to control which compositor target is depended on
Attachments
Patch
(3.43 KB, patch)
2012-08-03 16:06 PDT
,
James Robinson
no flags
Details
Formatted Diff
Diff
Patch
(4.92 KB, patch)
2012-08-03 21:27 PDT
,
James Robinson
no flags
Details
Formatted Diff
Diff
Patch for landing
(4.24 KB, patch)
2012-08-06 18:54 PDT
,
James Robinson
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
James Robinson
Comment 1
2012-08-03 16:06:43 PDT
Created
attachment 156474
[details]
Patch
James Robinson
Comment 2
2012-08-03 16:07:14 PDT
Just posting as an FYI for now, gyp will barf on this since <(DEPTH)/cc/cc.gyp does not exist yet.
Adam Barth
Comment 3
2012-08-03 16:14:37 PDT
Comment on
attachment 156474
[details]
Patch Don't you also need to add cc to DEPS?
James Robinson
Comment 4
2012-08-03 21:27:31 PDT
Created
attachment 156511
[details]
Patch
James Robinson
Comment 5
2012-08-03 21:30:34 PDT
https://chromiumcodereview.appspot.com/10824175/
has to land first or gclient will die processing the new DEPS entry.
Adam Barth
Comment 6
2012-08-03 23:32:08 PDT
Comment on
attachment 156511
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=156511&action=review
> Source/WebCore/WebCore.gyp/WebCore.gyp:2154 > + }, { # use_webkit_compositor==0
use_webkit_compositor -> use_libcc_for_compositor ?
James Robinson
Comment 7
2012-08-06 18:54:18 PDT
Created
attachment 156826
[details]
Patch for landing
WebKit Review Bot
Comment 8
2012-08-06 21:00:11 PDT
Comment on
attachment 156826
[details]
Patch for landing Clearing flags on attachment: 156826 Committed
r124845
: <
http://trac.webkit.org/changeset/124845
>
WebKit Review Bot
Comment 9
2012-08-06 21:00:15 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug