Bug 93164 - [Qt] UI_SIDE_COMPOSITING code has confusing names
Summary: [Qt] UI_SIDE_COMPOSITING code has confusing names
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-03 15:54 PDT by Noam Rosenthal
Modified: 2012-08-04 10:53 PDT (History)
15 users (show)

See Also:

Attachments
Patch (262.05 KB, patch)
2012-08-03 16:03 PDT, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Fixed CMakeLists.txt alphabetical order (262.82 KB, patch)
2012-08-03 16:46 PDT, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Removed unnecessary files from GTK build (263.61 KB, patch)
2012-08-03 17:06 PDT, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Renamed file in CMakeLists (263.62 KB, patch)
2012-08-03 17:41 PDT, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-08-03 15:54:02 PDT 
[Qt] UI_SIDE_COMPOSITING code has confusing names
Comment 1 Noam Rosenthal 2012-08-03 15:55:51 PDT 
The idea is to use CoordinatedGraphics as the directory and USE(COORDINATED_GRAPHICS) instead of USE(UI_SIDE_COMPOSITING).

Renames:
LayerBackingStore -> CoordinatedBackingStore
WebGraphicsLayer -> CoordinatedGraphicsLayer
WebLayerTreeRenderer -> LayerTreeRenderer
TiledBackingStoreRemoteTile -> CoordinatedTile
Comment 2 Kenneth Rohde Christiansen 2012-08-03 15:58:29 PDT 
Yes sounds very good
Comment 3 Noam Rosenthal 2012-08-03 16:03:47 PDT 
Created attachment 156473 [details]
Patch
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-08-03 16:18:11 PDT 
Comment on attachment 156473 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156473&action=review

I'd appreciate if if you kept the file list in WebKit2/CMakeLists.txt alphabetically sorted.

> Source/WebKit2/CMakeLists.txt:224
> -    UIProcess/LayerTreeCoordinatorProxy.cpp
> +    UIProcess/CoordinatedGraphics/ayerTreeCoordinatorProxy.cpp

Typo.
Comment 5 Noam Rosenthal 2012-08-03 16:46:38 PDT 
Created attachment 156481 [details]
Fixed CMakeLists.txt alphabetical order
Comment 6 Gustavo Noronha (kov) 2012-08-03 16:56:17 PDT 
Comment on attachment 156481 [details]
Fixed CMakeLists.txt alphabetical order

Attachment 156481 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13430579
Comment 7 Noam Rosenthal 2012-08-03 17:06:41 PDT 
Created attachment 156484 [details]
Removed unnecessary files from GTK build
Comment 8 Gyuyoung Kim 2012-08-03 17:28:45 PDT 
Comment on attachment 156484 [details]
Removed unnecessary files from GTK build

Attachment 156484 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13431528
Comment 9 Noam Rosenthal 2012-08-03 17:41:32 PDT 
Created attachment 156490 [details]
Renamed file in CMakeLists
Comment 10 WebKit Review Bot 2012-08-04 10:52:54 PDT 
Comment on attachment 156490 [details]
Renamed file in CMakeLists

Clearing flags on attachment: 156490

Committed r124701: <http://trac.webkit.org/changeset/124701>
Comment 11 WebKit Review Bot 2012-08-04 10:53:02 PDT 
All reviewed patches have been landed.  Closing bug.