Bug 93147 – [Qt] Use GraphicsLayerAnimation in LayerTreeCoordinator

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Noam Rosenthal]

As a preparation for threaded animations (93146), we should use an animation controller that doesn't use re-layouts and is synchronized with requestAnimationFrame, GraphicsLayerAnimation.

[Noam Rosenthal]

Created attachment 156725 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 156725 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156725&action=review

I think this looks fine.

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:792
> +    bool hasBigRotation;

shouldnt this be initialized? or is it an ignored value? like ignoredHasBigRotation;

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:818
> +
> +

double newline

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:218
> +
> +

double newline

[Noam Rosenthal]

Created attachment 156752 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 156752 [details]
Patch for landing

Rejecting attachment 156752 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13437876

[Noam Rosenthal]

Created attachment 156754 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 156754 [details]
Patch for landing

Clearing flags on attachment: 156754

Committed r124805: <http://trac.webkit.org/changeset/124805>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.