Bug 93147 - [Qt] Use GraphicsLayerAnimation in LayerTreeCoordinator
Summary: [Qt] Use GraphicsLayerAnimation in LayerTreeCoordinator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords:
Depends on:
Blocks: 93146
  Show dependency treegraph
 
Reported: 2012-08-03 11:44 PDT by Noam Rosenthal
Modified: 2012-08-06 16:01 PDT (History)
7 users (show)

See Also:


Attachments
Patch (18.23 KB, patch)
2012-08-06 10:59 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch for landing (18.25 KB, patch)
2012-08-06 13:19 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch for landing (18.26 KB, patch)
2012-08-06 13:29 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-08-03 11:44:17 PDT
As a preparation for threaded animations (93146), we should use an animation controller that doesn't use re-layouts and is synchronized with requestAnimationFrame, GraphicsLayerAnimation.
Comment 1 Noam Rosenthal 2012-08-06 10:59:29 PDT
Created attachment 156725 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-08-06 12:25:20 PDT
Comment on attachment 156725 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156725&action=review

I think this looks fine.

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:792
> +    bool hasBigRotation;

shouldnt this be initialized? or is it an ignored value? like ignoredHasBigRotation;

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:818
> +
> +

double newline

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:218
> +
> +

double newline
Comment 3 Noam Rosenthal 2012-08-06 13:19:22 PDT
Created attachment 156752 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-08-06 13:22:47 PDT
Comment on attachment 156752 [details]
Patch for landing

Rejecting attachment 156752 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13437876
Comment 5 Noam Rosenthal 2012-08-06 13:29:00 PDT
Created attachment 156754 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-08-06 16:01:22 PDT
Comment on attachment 156754 [details]
Patch for landing

Clearing flags on attachment: 156754

Committed r124805: <http://trac.webkit.org/changeset/124805>
Comment 7 WebKit Review Bot 2012-08-06 16:01:26 PDT
All reviewed patches have been landed.  Closing bug.