Bug 93141 - [BlackBerry] FrameLoaderClient::restoreViewState() shouldn't trigger painting
Summary: [BlackBerry] FrameLoaderClient::restoreViewState() shouldn't trigger painting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-03 10:46 PDT by Yong Li
Modified: 2012-08-03 12:58 PDT (History)
5 users (show)

See Also:

Attachments
the patch (6.41 KB, patch)
2012-08-03 10:56 PDT, Yong Li 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yong Li 2012-08-03 10:46:39 PDT 
It is neither safe nor efficient to paint contents in this function
Comment 1 Yong Li 2012-08-03 10:56:48 PDT 
Created attachment 156418 [details]
the patch
Comment 2 Rob Buis 2012-08-03 11:10:45 PDT 
Comment on attachment 156418 [details]
the patch

LGTM.
Comment 3 Antonio Gomes 2012-08-03 11:17:57 PDT 
Conscidence or not, this crash started appearing after Jakob's count-based suspend/resume backingstore patch.

cc him, as he last touched it.
Comment 4 Antonio Gomes 2012-08-03 11:18:28 PDT 
Jacky, Pepeto: feel free to comment...
Comment 5 Yong Li 2012-08-03 11:24:43 PDT 
Comment on attachment 156418 [details]
the patch

cancelling for now
Comment 6 Yong Li 2012-08-03 11:37:55 PDT 
Comment on attachment 156418 [details]
the patch

commit again. with nested suspend/resume, it is no longer safe to leave a single suspend call there. we can easily strip off the message when we find a better solution
Comment 7 WebKit Review Bot 2012-08-03 12:58:34 PDT 
Comment on attachment 156418 [details]
the patch

Clearing flags on attachment: 156418

Committed r124643: <http://trac.webkit.org/changeset/124643>
Comment 8 WebKit Review Bot 2012-08-03 12:58:38 PDT 
All reviewed patches have been landed.  Closing bug.