Bug 93124 - [BlackBerry] InspectorOverlay class duplicated in WebCore
Summary: [BlackBerry] InspectorOverlay class duplicated in WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konrad Piascik
URL:
Keywords:
Depends on: 90880
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-03 07:54 PDT by Konrad Piascik
Modified: 2012-08-07 12:09 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.26 KB, patch)
2012-08-03 08:47 PDT, Konrad Piascik 		no flags Details | Formatted Diff | Diff
Patch (13.91 KB, patch)
2012-08-03 12:58 PDT, Konrad Piascik 		no flags Details | Formatted Diff | Diff
Patch (15.52 KB, patch)
2012-08-07 11:12 PDT, Konrad Piascik 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konrad Piascik 2012-08-03 07:54:47 PDT 
https://bugs.webkit.org/show_bug.cgi?id=90880 refactored DOMNodeHighligher to include a new class WebCore::InspectorOverlay.  A WebCore::InspectorOverlay class already exists in Source/WebKit/BlackBerry/WebCoreSupport/InspectorOverlay.h

This bug will change the namespace of the class to BlackBerry::WebKit from WebCore to resolve this conflict.
Comment 1 Konrad Piascik 2012-08-03 08:47:33 PDT 
Created attachment 156389 [details]
Patch
Comment 2 Rob Buis 2012-08-03 08:49:33 PDT 
Comment on attachment 156389 [details]
Patch

LGTM.
Comment 3 Antonio Gomes 2012-08-03 09:25:59 PDT 
Comment on attachment 156389 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156389&action=review

> Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.cpp:32
> -namespace WebCore {
> +namespace BlackBerry {
> +namespace WebKit {
>  

I think it should be in WebKitSupport instead, no?
Comment 4 Konrad Piascik 2012-08-03 10:31:02 PDT 
(In reply to comment #3)
> (From update of attachment 156389 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=156389&action=review
> 
> > Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.cpp:32
> > -namespace WebCore {
> > +namespace BlackBerry {
> > +namespace WebKit {
> >  
> 
> I think it should be in WebKitSupport instead, no?

Is it OK to have the move as a separate commit?
Comment 5 WebKit Review Bot 2012-08-03 12:36:34 PDT 
Comment on attachment 156389 [details]
Patch

Clearing flags on attachment: 156389

Committed r124639: <http://trac.webkit.org/changeset/124639>
Comment 6 WebKit Review Bot 2012-08-03 12:36:38 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Konrad Piascik 2012-08-03 12:58:56 PDT 
Reopening to attach new patch.
Comment 8 Konrad Piascik 2012-08-03 12:58:58 PDT 
Created attachment 156441 [details]
Patch
Comment 9 Konrad Piascik 2012-08-03 12:59:47 PDT 
Comment on attachment 156441 [details]
Patch

forgot cmake changes
Comment 10 Konrad Piascik 2012-08-07 11:12:11 PDT 
Created attachment 156959 [details]
Patch
Comment 11 Rob Buis 2012-08-07 11:16:50 PDT 
Comment on attachment 156959 [details]
Patch

LGTM.
Comment 12 WebKit Review Bot 2012-08-07 12:09:49 PDT 
Comment on attachment 156959 [details]
Patch

Clearing flags on attachment: 156959

Committed r124905: <http://trac.webkit.org/changeset/124905>
Comment 13 WebKit Review Bot 2012-08-07 12:09:55 PDT 
All reviewed patches have been landed.  Closing bug.