Bug 93124 – [BlackBerry] InspectorOverlay class duplicated in WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Konrad Piascik]

https://bugs.webkit.org/show_bug.cgi?id=90880 refactored DOMNodeHighligher to include a new class WebCore::InspectorOverlay.  A WebCore::InspectorOverlay class already exists in Source/WebKit/BlackBerry/WebCoreSupport/InspectorOverlay.h

This bug will change the namespace of the class to BlackBerry::WebKit from WebCore to resolve this conflict.

[Konrad Piascik]

Created attachment 156389 [details]
Patch

[Rob Buis]

Comment on attachment 156389 [details]
Patch

LGTM.

[Antonio Gomes]

Comment on attachment 156389 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156389&action=review

> Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.cpp:32
> -namespace WebCore {
> +namespace BlackBerry {
> +namespace WebKit {
>  

I think it should be in WebKitSupport instead, no?

[Konrad Piascik]

(In reply to comment #3)
> (From update of attachment 156389 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=156389&action=review
> 
> > Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.cpp:32
> > -namespace WebCore {
> > +namespace BlackBerry {
> > +namespace WebKit {
> >  
> 
> I think it should be in WebKitSupport instead, no?

Is it OK to have the move as a separate commit?

[WebKit Review Bot]

Comment on attachment 156389 [details]
Patch

Clearing flags on attachment: 156389

Committed r124639: <http://trac.webkit.org/changeset/124639>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Konrad Piascik]

Reopening to attach new patch.

[Konrad Piascik]

Created attachment 156441 [details]
Patch

[Konrad Piascik]

Comment on attachment 156441 [details]
Patch

forgot cmake changes

[Konrad Piascik]

Created attachment 156959 [details]
Patch

[Rob Buis]

Comment on attachment 156959 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 156959 [details]
Patch

Clearing flags on attachment: 156959

Committed r124905: <http://trac.webkit.org/changeset/124905>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.