Bug 93118 – Add self to commiters.py

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Arvid Nilsson]

Hi, is this the right way to do it?

[Arvid Nilsson]

Created attachment 156372 [details]
Patch

[Adam Barth]

Comment on attachment 156372 [details]
Patch

Traditionally, folks just land these patches themselves with their shiny new committer credentials.  :)

[Antonio Gomes]

Comment on attachment 156372 [details]
Patch

Agree!

However, getting in touch with Apple folks about creating a svn account is not easy sometimes. Arvid has already received and returned all "new committer" paper work, but is still unable to use the power of auto-cq+ patches. So lets try to shortcut it for him this time :-)

[WebKit Review Bot]

Comment on attachment 156372 [details]
Patch

Clearing flags on attachment: 156372

Committed r124637: <http://trac.webkit.org/changeset/124637>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

> Arvid has already received and returned all "new committer" paper work, but is still unable to use the power of auto-cq+ patches. So lets try to shortcut it for him this time :-)

I think that you misunderstood Adam's suggestion. Commit queue won't work until one has their name in committers.py, that's entirely expected.

The idea is to modify committers.py manually (yes, svn ci or webkit-patch land). This also verifies that committer privileges are actually in place server side.

[Antonio Gomes]

(In reply to comment #6)
> > Arvid has already received and returned all "new committer" paper work, but is still unable to use the power of auto-cq+ patches. So lets try to shortcut it for him this time :-)
> 
> I think that you misunderstood Adam's suggestion. Commit queue won't work until one has their name in committers.py, that's entirely expected.
> 
> The idea is to modify committers.py manually (yes, svn ci or webkit-patch land). This also verifies that committer privileges are actually in place server side.

Hi AP. I, in fact, understood it well. However, people many people find it not easy to get someone from Apple to:

1) confirm the paper work got delivered and is on file properly;
2) get a slice of time of the person responsible for creating the svn account, email aliasing, etc, to actually get it done.

I agree with you that it is desirable that this specific check-in goes manually (through svn ci, git svn dcommit, etc), but in Arvid's case, given that he has a different timezone, being able to cq+ makes his productivity to increase.

Sorry about work-around'ing this step in this case. As I said, I agree with it.

[Alexey Proskuryakov]

> 1) confirm the paper work got delivered and is on file properly;

Are you saying that you don't know whether Arvid's paperwork is already on file?

> 2) get a slice of time of the person responsible for creating the svn account, email aliasing, etc, to actually get it done.

This seems unfortunate to me. Have you contacted anyone at Apple to get this improved?

[Antonio Gomes]

(In reply to comment #8)
> > 1) confirm the paper work got delivered and is on file properly;
> 
> Are you saying that you don't know whether Arvid's paperwork is already on file?

No, it was the case with another person: Konrad. He is ok now.
 
> > 2) get a slice of time of the person responsible for creating the svn account, email aliasing, etc, to actually get it done.
> 
> This seems unfortunate to me. Have you contacted anyone at Apple to get this improved?

I have not, but I can certainly do that. Who would be a good person to get in touch?

[Alexey Proskuryakov]

Adele Peterson and Brian Weinstein. I talked to them a little about this issue today.

[Antonio Gomes]

(In reply to comment #10)
> Adele Peterson and Brian Weinstein. I talked to them a little about this issue today.

Thanks Ap