The Android port allows tapping on the find-in-page result tickmarks taking the user to the corresponding matches. This functionality requires new methods in the WebFrame API. In order to achieve WebKit API compatibility as soon as possible we're landing first empty stubs of these new methods leaving the implementation to a later bug.
Created attachment 156365 [details] Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment on attachment 156365 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156365&action=review Thanks. > Source/WebKit/chromium/src/WebFrameImpl.cpp:1945 > + // FIXME(leandrogracia): implement this as part of https://bugs.webkit.org/show_bug.cgi?id=93111. FIXME(leandrogracia) -> FIXME WebKit doesn't use user names in FIXME comments. implement -> Implement We try to use English sentence punctuation in comments.
Created attachment 156409 [details] Patch
Comment on attachment 156365 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156365&action=review >> Source/WebKit/chromium/src/WebFrameImpl.cpp:1945 >> + // FIXME(leandrogracia): implement this as part of https://bugs.webkit.org/show_bug.cgi?id=93111. > > FIXME(leandrogracia) -> FIXME > > WebKit doesn't use user names in FIXME comments. > > implement -> Implement > > We try to use English sentence punctuation in comments. Done.
Comment on attachment 156409 [details] Patch Thanks.
(In reply to comment #6) > (From update of attachment 156409 [details]) > Thanks. Np. Thanks for reviewing.
Comment on attachment 156409 [details] Patch Clearing flags on attachment: 156409 Committed r124640: <http://trac.webkit.org/changeset/124640>
All reviewed patches have been landed. Closing bug.