Bug 93107 – [BlackBerry] Crash on layout test in mediaPlayer code

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[George Staikos]

Crash occurred here:

#0  BlackBerry::Platform::MMRPlayer::duration (this=0x0)
#1  0x794b8888 in WebCore::MediaPlayerPrivate::percentLoaded (this=0xf28848)
    at
Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:443
#2  0x794b3882 in WebCore::RenderThemeBlackBerry::paintMediaSliderTrack
(this=<optimized out>, object=<optimized out>, paintInfo=..., rect=...)
    at
Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:903

[George Staikos]

Created attachment 156351 [details]
Patch to fix it

[George Staikos]

Created attachment 156353 [details]
Patch (corrected patch)

[Rob Buis]

Comment on attachment 156353 [details]
Patch (corrected patch)

LGTM.

[Antonio Gomes]

(In reply to comment #0)
> Crash occurred here:
> 
> #0  BlackBerry::Platform::MMRPlayer::duration (this=0x0)
> #1  0x794b8888 in WebCore::MediaPlayerPrivate::percentLoaded (this=0xf28848)
>     at
> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:443
> #2  0x794b3882 in WebCore::RenderThemeBlackBerry::paintMediaSliderTrack
> (this=<optimized out>, object=<optimized out>, paintInfo=..., rect=...)
>     at
> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:903

do we know why it is 0x0? Does the test crash if run standalone?

[WebKit Review Bot]

Comment on attachment 156353 [details]
Patch (corrected patch)

Clearing flags on attachment: 156353

Committed r124609: <http://trac.webkit.org/changeset/124609>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[George Staikos]

(In reply to comment #4)
> (In reply to comment #0)
> > Crash occurred here:
> > 
> > #0  BlackBerry::Platform::MMRPlayer::duration (this=0x0)
> > #1  0x794b8888 in WebCore::MediaPlayerPrivate::percentLoaded (this=0xf28848)
> >     at
> > Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:443
> > #2  0x794b3882 in WebCore::RenderThemeBlackBerry::paintMediaSliderTrack
> > (this=<optimized out>, object=<optimized out>, paintInfo=..., rect=...)
> >     at
> > Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:903
> 
> do we know why it is 0x0? Does the test crash if run standalone?

Hm actually this might just be a lucky way to catch it.  It looks more like an out-of-memory situation that caused a malloc fail, now that I think about it.  The change doesn't hurt, but probably in practice doesn't help either, and the code is supposed to go away soon.  I'd suggest leave it for now.