Bug 93103 - [V8] Move V8Proxy methods that set DOM attributes/callbacks to V8Binding
Summary: [V8] Move V8Proxy methods that set DOM attributes/callbacks to V8Binding
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 85330
  Show dependency tree / graph
 
Reported: 2012-08-03 06:03 PDT by Kentaro Hara
Modified: 2012-08-05 14:59 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.64 KB, patch)
2012-08-03 06:15 PDT, Kentaro Hara 		abarth: commit-queue-
Details | Formatted Diff | Diff
patch for landing (10.72 KB, patch)
2012-08-05 07:11 PDT, Kentaro Hara 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
patch for landing (10.50 KB, patch)
2012-08-05 10:08 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-03 06:03:00 PDT 
To remove V8Proxy, we can move V8Proxy methods that set DOM attributes/callbacks to V8Binding.
Comment 1 Kentaro Hara 2012-08-03 06:15:00 PDT 
Created attachment 156346 [details]
Patch
Comment 2 Adam Barth 2012-08-03 09:49:26 PDT 
Comment on attachment 156346 [details]
Patch

Can we put this code into it's own header?  We don't want to make V8Bindings.h into the new V8Proxy all-sing, all-dance file.
Comment 3 Kentaro Hara 2012-08-03 09:53:50 PDT 
(In reply to comment #2)
> (From update of attachment 156346 [details])
> Can we put this code into it's own header?  We don't want to make V8Bindings.h into the new V8Proxy all-sing, all-dance file.

Sure. Let me commit it tomorrow.
Comment 4 Kentaro Hara 2012-08-05 07:11:54 PDT 
Created attachment 156560 [details]
patch for landing
Comment 5 Kentaro Hara 2012-08-05 07:16:12 PDT 
(In reply to comment #2)
> (From update of attachment 156346 [details])
> Can we put this code into it's own header?  We don't want to make V8Bindings.h into the new V8Proxy all-sing, all-dance file.

Let me land this patch first. I found that there are already a couple of methods in V8Binding that should be moved to the own header (e.g. configureTemplate()). I'll move all the methods at a breath in a follow-up patch.
Comment 6 WebKit Review Bot 2012-08-05 08:38:15 PDT 
Comment on attachment 156560 [details]
patch for landing

Rejecting attachment 156560 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
og
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/bindings/v8/V8Binding.cpp
patching file Source/WebCore/bindings/v8/V8Binding.h
patching file Source/WebCore/bindings/v8/V8Proxy.cpp
Hunk #1 FAILED at 84.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/v8/V8Proxy.cpp.rej
patching file Source/WebCore/bindings/v8/V8Proxy.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13443144
Comment 7 Kentaro Hara 2012-08-05 10:08:48 PDT 
Created attachment 156565 [details]
patch for landing
Comment 8 WebKit Review Bot 2012-08-05 11:40:40 PDT 
Comment on attachment 156565 [details]
patch for landing

Clearing flags on attachment: 156565

Committed r124718: <http://trac.webkit.org/changeset/124718>