Bug 93102 - [CSSRegions]regionOverset is computed as "overset" even though the region is not the last in the chain
Summary: [CSSRegions]regionOverset is computed as "overset" even though the region is ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 57312
  Show dependency treegraph
 
Reported: 2012-08-03 05:56 PDT by Andrei Onea
Modified: 2012-08-14 13:53 PDT (History)
4 users (show)

See Also:


Attachments
Patch (9.53 KB, patch)
2012-08-03 06:05 PDT, Andrei Onea
no flags Details | Formatted Diff | Diff
Patch (11.99 KB, patch)
2012-08-08 07:53 PDT, Andrei Onea
no flags Details | Formatted Diff | Diff
Patch (9.33 KB, patch)
2012-08-08 10:01 PDT, Andrei Onea
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Onea 2012-08-03 05:56:44 PDT
The latest CSSRegions spec says that Element.regionOverflow should only return "'overflow" for the last region in the region chain, if the content cannot fit inside it. http://dev.w3.org/csswg/css3-regions/#dom-region-regionoverset . The current implementation uses the older spec, which allows regions that are not the last in the region chain to have the regionOverflow property set to "overflow".
Comment 1 Andrei Onea 2012-08-03 06:05:08 PDT
Created attachment 156344 [details]
Patch
Comment 2 Andrei Onea 2012-08-08 07:53:53 PDT
Created attachment 157219 [details]
Patch

Modified patch to use regionOverset property and overset property value
Comment 3 Allan Sandfeld Jensen 2012-08-08 09:21:24 PDT
Comment on attachment 157219 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157219&action=review

> LayoutTests/ChangeLog:14
> +        * fast/regions/element-region-overflow-state-expected.txt:
> +        * fast/regions/element-region-overflow-state-vertical-rl-expected.txt:
> +        * fast/regions/element-region-overflow-state-vertical-rl.html:
> +        * fast/regions/element-region-overflow-state.html:

I think you need to update the changelog it doesn't match the files changed below.
Comment 4 Andrei Onea 2012-08-08 10:01:34 PDT
Created attachment 157239 [details]
Patch
Comment 5 Eric Seidel (no email) 2012-08-14 13:25:19 PDT
Comment on attachment 157239 [details]
Patch

OK.
Comment 6 WebKit Review Bot 2012-08-14 13:53:26 PDT
Comment on attachment 157239 [details]
Patch

Clearing flags on attachment: 157239

Committed r125600: <http://trac.webkit.org/changeset/125600>
Comment 7 WebKit Review Bot 2012-08-14 13:53:29 PDT
All reviewed patches have been landed.  Closing bug.