Bug 93100 – Remove minimum window size for PagePopup

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Keishi Hattori]

Right now PagePopup cannot be resized below 100x100 pixels.

[Keishi Hattori]

Created attachment 156343 [details]
Patch

[Kent Tamura]

Comment on attachment 156343 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156343&action=review

> Source/WebCore/page/Chrome.cpp:567
> +#if ENABLE(PAGE_POPUP)
> +    if (DOMWindowPagePopup::from(window))
> +        return FloatSize(0, 0);
> +#endif
> +    return FloatSize(100, 100);

I feel this is a violation for the concept of Supplement. Checking existence of a Supplement in a class unrelated to the Supplement looks wrong.

We should
 - Add minimumSizeForWindow to ChromeClient.  Not Chrome.
  I think its's ok that ChromeClient.h has a default implementation which reutrns FloatSize(100,100).
 - PagePopupChromeClient in WebPagePopupImpl.cpp overrides it.

[Keishi Hattori]

Created attachment 156602 [details]
Patch

[Kent Tamura]

Comment on attachment 156602 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156602&action=review

> Source/WebCore/page/Chrome.cpp:61
> +#if ENABLE(PAGE_POPUP)
> +#include "DOMWindowPagePopup.h"
> +#endif
> +

unnecessary change

> Source/WebCore/page/Chrome.h:44
> +    class DOMWindow;

unnecessary change

> Source/WebCore/page/ChromeClient.h:354
> +        virtual FloatSize minimumSizeForWindow() const { return FloatSize(100, 100); };

nit: I prefer 'minimumWindowSize'.

> Source/WebCore/page/DOMWindow.cpp:342
> +    FloatSize minimumSize = page ? m_frame->page()->chrome()->minimumSizeForWindow() : FloatSize(100, 100);

We can call ChromeClient::minimumSizeForWindow() here.  So we don't need to change Chrome.{cpp.h} in this patch.

> Source/WebKit/chromium/src/WebPagePopupImpl.cpp:126
> +    virtual FloatSize minimumSizeForWindow() const

Please add OVERRIDE.

> Source/WebKit/chromium/src/WebPagePopupImpl.cpp:212
> +    ASSERT(frame->existingDOMWindow());
> +    DOMWindowPagePopup::install(frame->existingDOMWindow(), m_popupClient);
> +

This change is unnecessary.

[Keishi Hattori]

Created attachment 156612 [details]
Patch

[Kent Tamura]

Comment on attachment 156612 [details]
Patch

ok

[WebKit Review Bot]

Comment on attachment 156612 [details]
Patch

Clearing flags on attachment: 156612

Committed r124753: <http://trac.webkit.org/changeset/124753>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.