Bug 93088 – [Chromium] WebTouchCandidatesInfo should be part of the Client API

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Peter Beverloo]

[Chromium] Add a forwarding header for WebTouchCandidatesInfo

[Peter Beverloo]

Created attachment 156324 [details]
Patch

[Peter Beverloo]

Will files like this remain necessary, or will we be able to access the Source/Platform/chromium/public/* directory directly at some point? Files like this are kind of.. meh.

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adam Barth]

Comment on attachment 156324 [details]
Patch

Sorry, I missed that WebTouchCandidatesInfo was in Platform.  We probably should move it to WebKit/chromium/public.  Things related to events (e.g., mouse, touch) aren't concerns of the platform.

[Adam Barth]

> Will files like this remain necessary, or will we be able to access the Source/Platform/chromium/public/* directory directly at some point? Files like this are kind of.. meh.

We'll be able to include from Platform/chromium/public directly.  That's pretty high on my list for after chromium-android is upstream.

[Adam Barth]

Created attachment 156564 [details]
Patch

[Peter Beverloo]

(In reply to comment #4)
> (From update of attachment 156324 [details])
> Sorry, I missed that WebTouchCandidatesInfo was in Platform.  We probably should move it to WebKit/chromium/public.  Things related to events (e.g., mouse, touch) aren't concerns of the platform.

Got it. Abroad now, but I can take this tomorrow. How exactly is the difference defined? I.e. what goes in Source/Platform?

[Peter Beverloo]

(In reply to comment #6)
> Created an attachment (id=156564) [details]
> Patch

..or not :-). Thanks.

[WebKit Review Bot]

Comment on attachment 156564 [details]
Patch

Attachment 156564 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13435550

[Adam Barth]

> Got it. Abroad now, but I can take this tomorrow. How exactly is the difference defined? I.e. what goes in Source/Platform?

Here's a diagram that tries to explain it:

https://docs.google.com/drawings/d/1GJXd6XSLEehvuqA7Xbvbz0OH6Znnr2iTijihjrEY0ts/edit

I should expand http://trac.webkit.org/wiki/ChromiumWebKitAPI to explain more.  The idea is that Platform is the API to the lower layers of the system (e.g., OS facilities) whereas the Client API (the one in WebKit/chromium/public) is the one that the higher levels of the system use to communicate with WebKit.

[Adam Barth]

Created attachment 156768 [details]
Patch

[WebKit Review Bot]

Comment on attachment 156768 [details]
Patch

Clearing flags on attachment: 156768

Committed r124813: <http://trac.webkit.org/changeset/124813>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Peter Beverloo]

A bit late, but thank you for doing this, Adam!