[Chromium] Add a forwarding header for WebTouchCandidatesInfo
Created attachment 156324 [details] Patch
Will files like this remain necessary, or will we be able to access the Source/Platform/chromium/public/* directory directly at some point? Files like this are kind of.. meh.
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment on attachment 156324 [details] Patch Sorry, I missed that WebTouchCandidatesInfo was in Platform. We probably should move it to WebKit/chromium/public. Things related to events (e.g., mouse, touch) aren't concerns of the platform.
> Will files like this remain necessary, or will we be able to access the Source/Platform/chromium/public/* directory directly at some point? Files like this are kind of.. meh. We'll be able to include from Platform/chromium/public directly. That's pretty high on my list for after chromium-android is upstream.
Created attachment 156564 [details] Patch
(In reply to comment #4) > (From update of attachment 156324 [details]) > Sorry, I missed that WebTouchCandidatesInfo was in Platform. We probably should move it to WebKit/chromium/public. Things related to events (e.g., mouse, touch) aren't concerns of the platform. Got it. Abroad now, but I can take this tomorrow. How exactly is the difference defined? I.e. what goes in Source/Platform?
(In reply to comment #6) > Created an attachment (id=156564) [details] > Patch ..or not :-). Thanks.
Comment on attachment 156564 [details] Patch Attachment 156564 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13435550
> Got it. Abroad now, but I can take this tomorrow. How exactly is the difference defined? I.e. what goes in Source/Platform? Here's a diagram that tries to explain it: https://docs.google.com/drawings/d/1GJXd6XSLEehvuqA7Xbvbz0OH6Znnr2iTijihjrEY0ts/edit I should expand http://trac.webkit.org/wiki/ChromiumWebKitAPI to explain more. The idea is that Platform is the API to the lower layers of the system (e.g., OS facilities) whereas the Client API (the one in WebKit/chromium/public) is the one that the higher levels of the system use to communicate with WebKit.
Created attachment 156768 [details] Patch
Comment on attachment 156768 [details] Patch Clearing flags on attachment: 156768 Committed r124813: <http://trac.webkit.org/changeset/124813>
All reviewed patches have been landed. Closing bug.
A bit late, but thank you for doing this, Adam!