Bug 93067 - Add *explicit* keyword to constructors in WebCore/accessibility
Summary: Add *explicit* keyword to constructors in WebCore/accessibility
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-02 22:40 PDT by Gyuyoung Kim
Modified: 2012-08-03 01:41 PDT (History)
4 users (show)

See Also:


Attachments
Patch (14.09 KB, patch)
2012-08-02 22:42 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-08-02 22:40:36 PDT
As a step to add *explicit* keyword to constructors which have a parameter, *explicit* keyword is added to Source/WebCore/accessibility in order to avoid implicit type conversion.
Comment 1 Gyuyoung Kim 2012-08-02 22:42:58 PDT
Created attachment 156263 [details]
Patch
Comment 2 Kentaro Hara 2012-08-02 22:46:33 PDT
Comment on attachment 156263 [details]
Patch

Looks OK but I'm not 100% sure if it won't break anything. Please cq+ it when you can watch the tree.
Comment 3 Gyuyoung Kim 2012-08-02 22:47:23 PDT
(In reply to comment #2)
> (From update of attachment 156263 [details])
> Looks OK but I'm not 100% sure if it won't break anything. Please cq+ it when you can watch the tree.

Sure, I will check them. Thanks.
Comment 4 Gyuyoung Kim 2012-08-03 00:46:39 PDT
Comment on attachment 156263 [details]
Patch

It looks this patch doesn't make build problems. So, I set cq+
Comment 5 WebKit Review Bot 2012-08-03 01:41:25 PDT
Comment on attachment 156263 [details]
Patch

Clearing flags on attachment: 156263

Committed r124582: <http://trac.webkit.org/changeset/124582>
Comment 6 WebKit Review Bot 2012-08-03 01:41:29 PDT
All reviewed patches have been landed.  Closing bug.