RESOLVED FIXED Bug 93067
Add *explicit* keyword to constructors in WebCore/accessibility 
https://bugs.webkit.org/show_bug.cgi?id=93067
Summary Add *explicit* keyword to constructors in WebCore/accessibility
Gyuyoung Kim
Reported 2012-08-02 22:40:36 PDT
As a step to add *explicit* keyword to constructors which have a parameter, *explicit* keyword is added to Source/WebCore/accessibility in order to avoid implicit type conversion.
Attachments
Patch (14.09 KB, patch)
2012-08-02 22:42 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-08-02 22:42:58 PDT
Created attachment 156263 [details] Patch
Kentaro Hara
Comment 2 2012-08-02 22:46:33 PDT
Comment on attachment 156263 [details] Patch Looks OK but I'm not 100% sure if it won't break anything. Please cq+ it when you can watch the tree.
Gyuyoung Kim
Comment 3 2012-08-02 22:47:23 PDT
(In reply to comment #2) > (From update of attachment 156263 [details]) > Looks OK but I'm not 100% sure if it won't break anything. Please cq+ it when you can watch the tree. Sure, I will check them. Thanks.
Gyuyoung Kim
Comment 4 2012-08-03 00:46:39 PDT
Comment on attachment 156263 [details] Patch It looks this patch doesn't make build problems. So, I set cq+
WebKit Review Bot
Comment 5 2012-08-03 01:41:25 PDT
Comment on attachment 156263 [details] Patch Clearing flags on attachment: 156263 Committed r124582: <http://trac.webkit.org/changeset/124582>
WebKit Review Bot
Comment 6 2012-08-03 01:41:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.