Bug 93062 - [chromium] Move ubercomp quads back into CC
Summary: [chromium] Move ubercomp quads back into CC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandre Elias
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-02 19:13 PDT by Alexandre Elias
Modified: 2012-08-03 09:26 PDT (History)
11 users (show)

See Also:


Attachments
Patch (127.60 KB, patch)
2012-08-02 19:19 PDT, Alexandre Elias
no flags Details | Formatted Diff | Diff
Patch (127.01 KB, patch)
2012-08-02 19:32 PDT, Alexandre Elias
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Elias 2012-08-02 19:13:48 PDT
[chromium] Move ubercomp quads back into CC
Comment 1 Alexandre Elias 2012-08-02 19:19:32 PDT
Created attachment 156239 [details]
Patch
Comment 2 Alexandre Elias 2012-08-02 19:20:34 PDT
Thank goodness for regexps and regularized naming conventions :).
Comment 3 WebKit Review Bot 2012-08-02 19:23:48 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 James Robinson 2012-08-02 19:27:12 PDT
Comment on attachment 156239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156239&action=review

Could you fix the .gyp and reupload for EWS?

> Source/Platform/Platform.gypi:123
> -            'chromium/public/WebTransformationMatrix.h',
> +            'chromium/public/WebKit::WebTransformationMatrix.h',

I think your regex went a bit awry here - this probably won't work

> Source/WebCore/platform/graphics/chromium/cc/CCSharedQuadState.h:36
> +class CCSharedQuadState {
> +public:

Can you just make this be a struct?

> Source/WebCore/platform/graphics/chromium/cc/CCSharedQuadState.h:48
> +    CCSharedQuadState();

Do you need this?
Comment 5 Alexandre Elias 2012-08-02 19:32:45 PDT
Created attachment 156243 [details]
Patch

Fixed gyp mistake and changed CCSharedQuadState
Comment 6 WebKit Review Bot 2012-08-03 09:26:15 PDT
Comment on attachment 156243 [details]
Patch

Clearing flags on attachment: 156243

Committed r124621: <http://trac.webkit.org/changeset/124621>
Comment 7 WebKit Review Bot 2012-08-03 09:26:20 PDT
All reviewed patches have been landed.  Closing bug.