Bug 93062 – [chromium] Move ubercomp quads back into CC

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alexandre Elias]

[chromium] Move ubercomp quads back into CC

[Alexandre Elias]

Created attachment 156239 [details]
Patch

[Alexandre Elias]

Thank goodness for regexps and regularized naming conventions :).

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[James Robinson]

Comment on attachment 156239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156239&action=review

Could you fix the .gyp and reupload for EWS?

> Source/Platform/Platform.gypi:123
> -            'chromium/public/WebTransformationMatrix.h',
> +            'chromium/public/WebKit::WebTransformationMatrix.h',

I think your regex went a bit awry here - this probably won't work

> Source/WebCore/platform/graphics/chromium/cc/CCSharedQuadState.h:36
> +class CCSharedQuadState {
> +public:

Can you just make this be a struct?

> Source/WebCore/platform/graphics/chromium/cc/CCSharedQuadState.h:48
> +    CCSharedQuadState();

Do you need this?

[Alexandre Elias]

Created attachment 156243 [details]
Patch

Fixed gyp mistake and changed CCSharedQuadState

[WebKit Review Bot]

Comment on attachment 156243 [details]
Patch

Clearing flags on attachment: 156243

Committed r124621: <http://trac.webkit.org/changeset/124621>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.