Bug 93035 - writeHelperGetString in V8HTMLDocument uses += to concatenate strings
Summary: writeHelperGetString in V8HTMLDocument uses += to concatenate strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords: EasyFix
Depends on:
Blocks:
 
Reported: 2012-08-02 15:26 PDT by WebKit Review Bot
Modified: 2012-08-08 18:41 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.95 KB, patch)
2012-08-08 17:04 PDT, Jae Hyun Park 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-08-02 15:26:35 PDT 
writeHelperGetString in V8HTMLDocument uses += to concatenate strings
Requested by abarth on #webkit.
Comment 1 Adam Barth 2012-08-02 15:29:47 PDT 
This should use StringBuilder instead.  Feel free to steal this bug from me.
Comment 2 Jae Hyun Park 2012-08-08 17:04:32 PDT 
Created attachment 157340 [details]
Patch
Comment 3 Adam Barth 2012-08-08 17:05:33 PDT 
Comment on attachment 157340 [details]
Patch

Yay!  Thanks!
Comment 4 WebKit Review Bot 2012-08-08 18:10:16 PDT 
Comment on attachment 157340 [details]
Patch

Clearing flags on attachment: 157340

Committed r125132: <http://trac.webkit.org/changeset/125132>
Comment 5 WebKit Review Bot 2012-08-08 18:10:20 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Jae Hyun Park 2012-08-08 18:41:16 PDT 
(In reply to comment #3)
> (From update of attachment 157340 [details])
> Yay!  Thanks!

Thank you for your review.