Bug 93034 – Unprefix window.webkitURL

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Kinuko Yasuda]

Both FF and Opera 12 have window.URL unprefixed and it looks like probably we're ready to unprefix it too.

Given that we've exposed prefixed version of webkitURL sometime now (in Safari 6 and Chrome) maybe we should preserve the prefixed version for a while.

[Kinuko Yasuda]

Created attachment 156255 [details]
Patch

[WebKit Review Bot]

Comment on attachment 156255 [details]
Patch

Attachment 156255 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13415917

New failing tests:
compositing/geometry/object-clip-rects-assertion.html

[WebKit Review Bot]

Created attachment 156276 [details]
Archive of layout-test-results from gce-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Build Bot]

Comment on attachment 156255 [details]
Patch

Attachment 156255 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13417861

New failing tests:
fast/dom/constructed-objects-prototypes.html

[Build Bot]

Created attachment 156312 [details]
Archive of layout-test-results from apple-mac-5

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: apple-mac-5  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.7.4

[Kinuko Yasuda]

Created attachment 156799 [details]
Patch

[Jian Li]

Comment on attachment 156799 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156799&action=review

> Source/WebCore/ChangeLog:9
> +        (This patch doesn't remove webkitURL yet as Safari and Chrome has exposed the URL for a while now.)

Is webkitURL exposed in Safari?

> LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions.html:8
> +description("Test instanceof functions and properties of URL.");

Might be better to mention both webkitURL and URL here.

> LayoutTests/platform/chromium-win/compositing/geometry/object-clip-rects-assertion-expected.txt:-1
> -This testcase should not fire an assertion related to clip rects.

Why do you change this file?

[Kinuko Yasuda]

Comment on attachment 156799 [details]
Patch

Thanks!  Will be landing with the suggested fix.

View in context: https://bugs.webkit.org/attachment.cgi?id=156799&action=review

>> Source/WebCore/ChangeLog:9
>> +        (This patch doesn't remove webkitURL yet as Safari and Chrome has exposed the URL for a while now.)
> 
> Is webkitURL exposed in Safari?

Looks like Safari6 does. http://caniuse.com/#feat=bloburls

>> LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions.html:8
>> +description("Test instanceof functions and properties of URL.");
> 
> Might be better to mention both webkitURL and URL here.

Will do.

>> LayoutTests/platform/chromium-win/compositing/geometry/object-clip-rects-assertion-expected.txt:-1
>> -This testcase should not fire an assertion related to clip rects.
> 
> Why do you change this file?

This looks same as the common expectation baseline. (I'll watch if this change doesn't break the test on bots)

[Kinuko Yasuda]

Committed r125149: <http://trac.webkit.org/changeset/125149>