glima has been having some trouble building WebKit-EFL without building the dependencies with jhbuild. One of the problems is: In file included from /home/glima/devel/webkit/Source/WebCore/platform/graphics/freetype/FontPlatformData.h:33:0, from /home/glima/devel/webkit/Source/WebCore/platform/graphics/FontPlatformData.h:35, from /home/glima/devel/webkit/Source/WebCore/platform/graphics/SimpleFontData.h:30, from /home/glima/devel/webkit/Source/WebCore/platform/graphics/FontFallbackList.h:25, from /home/glima/devel/webkit/Source/WebCore/platform/graphics/Font.h:29, from /home/glima/devel/webkit/Source/WebCore/platform/PopupMenuStyle.h:30, from /home/glima/devel/webkit/Source/WebCore/platform/PopupMenuClient.h:26, from /home/glima/devel/webkit/Source/WebCore/page/ChromeClient.h:33, from /home/glima/devel/webkit/Source/WebCore/Modules/webdatabase/DatabaseContext.cpp:34: /home/glima/devel/webkit/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:34:16: fatal error: hb.h: No such file or directory compilation terminated. I think there are problems when building Source/WebKit as well. This can be solved by including ${HARFBUZZ_INCLUDE_DIRS} in the include path.
I've finished building here and couldn't reproduce the issue (I was able to do so on another system). The harfbuzz include path seems to be added via EVAS_INCLUDE_DIRS, as `pkg-config --cflags-only-I evas' returns, among others, -I${WEBKITOUTPUUTDIR}/Dependencies/Root/include/harfbuzz. Are you building the port with build-webkit or using CMake on your own? In case it's the latter, I suspect evas may have been built without harfbuzz support and the flag is thus absent from your evas.pc. In case it's the former, I'd like to see the output of `./Tools/efl/run-with-jhbuild pkg-config --cflags-only-I evas'.
(In reply to comment #1) > The harfbuzz include path seems to be added via EVAS_INCLUDE_DIRS, as `pkg-config --cflags-only-I evas' returns, among others, -I${WEBKITOUTPUUTDIR}/Dependencies/Root/include/harfbuzz. (Relying on this is wrong, by the way, but I'd like to pinpoint where the problem is before trying to fix it).
(In reply to comment #1) > I've finished building here and couldn't reproduce the issue (I was able to do so on another system). ... Thinking of it again, I was able to reproduce this when I was testing my FindEFL.cmake rewrite, which gets rid of those implicit dependencies I mentioned in the previous comments, so it makes sense to have experienced the same build problem.
The problem occurs with a build without build-webkit usage, but pristine cmake. Evas without harfbuzz linkage too. I've just found out that a harfbuzzy Evas will let the build go, but apparently this should not be a requirement. My 2 cents.
Created attachment 159850 [details] Patch
Makes sense to me, thanks for catching this.
Comment on attachment 159850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159850&action=review LGTM. > Source/WebCore/PlatformEfl.cmake:158 > + ${HARFBUZZ_INCLUDE_DIRS} Is the indenting correct here?
Yep, we're just not using quotes.
Comment on attachment 159850 [details] Patch Clearing flags on attachment: 159850 Committed r126305: <http://trac.webkit.org/changeset/126305>
All reviewed patches have been landed. Closing bug.