Bug 93005 - Web Inspector: [Elements] Implement decorations for nodes with DOM breakpoints
Summary: Web Inspector: [Elements] Implement decorations for nodes with DOM breakpoints
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks: 116924
  Show dependency tree / graph
 
Reported: 2012-08-02 10:05 PDT by Alexander Pavlov (apavlov)
Modified: 2014-11-28 19:23 PST (History)
12 users (show)

See Also:

Attachments
Patch (16.64 KB, patch)
2012-08-03 09:40 PDT, Alexander Pavlov (apavlov) 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-07 (583.33 KB, application/zip)
2012-08-03 10:22 PDT, WebKit Review Bot 		no flags Details
Patch (17.03 KB, patch)
2012-08-06 01:22 PDT, Alexander Pavlov (apavlov) 		pfeldman: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2012-08-02 10:05:29 PDT 
This should look similar to decoration of elements with forced pseudo state.

Patch to follow.
Comment 1 Alexander Pavlov (apavlov) 2012-08-03 09:40:02 PDT 
Created attachment 156400 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-03 10:22:25 PDT 
Comment on attachment 156400 [details]
Patch

Attachment 156400 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13424767

New failing tests:
inspector/debugger/dom-breakpoints.html
Comment 3 WebKit Review Bot 2012-08-03 10:22:33 PDT 
Created attachment 156408 [details]
Archive of layout-test-results from gce-cr-linux-07

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 4 Alexander Pavlov (apavlov) 2012-08-06 01:22:48 PDT 
Created attachment 156616 [details]
Patch
Comment 5 Pavel Feldman 2012-08-06 02:54:35 PDT 
Comment on attachment 156616 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156616&action=review

> Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js:63
> +        this._updateNodeBreakpointCountCallback = callback;

You decorator should instead allow adding a listener on itself.

> Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js:75
> +    breakpointTypeLabels: function(node)

This should be private.

> Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js:364
> +WebInspector.DOMBreakpointsSidebarPane.DOMBreakpointsDecorator = function()

WebInspector.DOMBreakpointsSidebarPane.Decorator ? (to keep things short)

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:627
> +    {

Please declare interfaces as styleClass: function() { }

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:1676
> +                computeDecorationClass(decorator);

What are you trying to do here?