Bug 93005 – Web Inspector: [Elements] Implement decorations for nodes with DOM breakpoints

• Status: RESOLVED
• Resolution: INVALID
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

This should look similar to decoration of elements with forced pseudo state.

Patch to follow.

[Alexander Pavlov (apavlov)]

Created attachment 156400 [details]
Patch

[WebKit Review Bot]

Comment on attachment 156400 [details]
Patch

Attachment 156400 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13424767

New failing tests:
inspector/debugger/dom-breakpoints.html

[WebKit Review Bot]

Created attachment 156408 [details]
Archive of layout-test-results from gce-cr-linux-07

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Alexander Pavlov (apavlov)]

Created attachment 156616 [details]
Patch

[Pavel Feldman]

Comment on attachment 156616 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156616&action=review

> Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js:63
> +        this._updateNodeBreakpointCountCallback = callback;

You decorator should instead allow adding a listener on itself.

> Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js:75
> +    breakpointTypeLabels: function(node)

This should be private.

> Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js:364
> +WebInspector.DOMBreakpointsSidebarPane.DOMBreakpointsDecorator = function()

WebInspector.DOMBreakpointsSidebarPane.Decorator ? (to keep things short)

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:627
> +    {

Please declare interfaces as styleClass: function() { }

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:1676
> +                computeDecorationClass(decorator);

What are you trying to do here?