Bug 92999 - Web Inspector: Make textModel private to textEditor
Summary: Web Inspector: Make textModel private to textEditor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jan Keromnes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-02 09:16 PDT by Jan Keromnes
Modified: 2012-08-03 02:03 PDT (History)
11 users (show)

See Also:


Attachments
Patch (16.91 KB, patch)
2012-08-02 12:19 PDT, Jan Keromnes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Keromnes 2012-08-02 09:16:48 PDT
The textModel belongs to the textEditor and should be private to it. Currently, it is created outside textEditor and is sometimes accessed directly by a SourceFrame, JavaScriptSourceFrame or UISourceCodeFrame.
Comment 1 Jan Keromnes 2012-08-02 12:19:34 PDT
Created attachment 156137 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-03 02:03:21 PDT
Comment on attachment 156137 [details]
Patch

Clearing flags on attachment: 156137

Committed r124584: <http://trac.webkit.org/changeset/124584>
Comment 3 WebKit Review Bot 2012-08-03 02:03:26 PDT
All reviewed patches have been landed.  Closing bug.