When setting region-overflow: break; on a region, the content that "spills" out of the last region should break as if it was going to continue in another region and *NOT* be rendered anymore. Currently, the content that overflows the last region is not broken and get rendered as if overflowing.
Created attachment 156101 [details] Ref test highlighting the problem
Created attachment 156526 [details] Patch
Comment on attachment 156526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156526&action=review The change looks fine. By the way - probably related - but shouldn't RenderBlock::hasNextPage be changed too? AFAICT we shouldn't have an extra page after the last region if it has region-overflow: break but the code seems to imply that we do. > LayoutTests/fast/regions/region-overflow-break-expected.html:15 > +#gray { > overflow:visible; > } This doesn't look fine but I guess it is expected because we don't implement forced region breaking. I would put a FIXME as it's confusing if you don't know our current implementation.
Created attachment 157695 [details] Patch for landing
Comment on attachment 157695 [details] Patch for landing Clearing flags on attachment: 157695 Committed r125271: <http://trac.webkit.org/changeset/125271>
All reviewed patches have been landed. Closing bug.