Fail- itemType.add should treat \t as a space assert_equals: expected "a\tb" but got "a\t b" Sample test: test(function () { var elem = makeEl('div',{itemtype:'a\t'}); elem.itemType.add('b'); assert_equals(elem.itemType.toString(),'a\tb'); }, 'itemType.add should treat \\t as a space'); Expected result: itemType.toString() should return "a\tb" Actual: Returns "a\t b". Please note that we have same issue in case of \r, \n and \f Above can also be observed with following attributes: itemref, itemprop
Created attachment 157463 [details] Patch
Comment on attachment 157463 [details] Patch Attachment 157463 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13458705 New failing tests: fast/dom/HTMLElement/class-list.html fast/dom/HTMLElement/class-list-quirks.html fast/dom/HTMLOutputElement/dom-settable-token-list.html
Created attachment 157473 [details] Archive of layout-test-results from gce-cr-linux-06 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 157492 [details] Patch for review
Comment on attachment 157492 [details] Patch for review View in context: https://bugs.webkit.org/attachment.cgi?id=157492&action=review > Source/WebCore/html/DOMTokenList.cpp:59 > + if (!isHTMLSpace(input[input.length()-1])) I know this was also true in the old code but there should be a space around -. > LayoutTests/fast/dom/MicroData/domsettabletokenlist-attributes-add-token.html:21 > + debug("PASS: " + description); You can use testPassed. > LayoutTests/fast/dom/MicroData/domsettabletokenlist-attributes-add-token.html:23 > + debug("FAIL: " + description + " expected '" + expected + "' but got " + actual); and testFailed. > LayoutTests/fast/dom/MicroData/domsettabletokenlist-attributes-add-token.html:27 > +createElement('itemref', 'a '); It looks as if itemref is an element name. Probably better to rename createElement to createDivWithAttribute.
Committed r125257: <http://trac.webkit.org/changeset/125257>