Bug 92990 – Web Inspector: Rename 'User agent' to 'Overrides' in settings screen

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Addy Osmani]

As the User agent tab in the settings screen has evolved over time to include override capabilities for more than just the user agent, I think we should rename this to 'Overrides', which better describes what the tab contains.

[Addy Osmani]

Created attachment 156088 [details]
Patch

[Pavel Feldman]

Comment on attachment 156088 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156088&action=review

> Source/WebCore/inspector/front-end/SettingsScreen.js:48
> +    this._tabbedPane.appendTab(WebInspector.SettingsScreen.Tabs.UserAgent, WebInspector.UIString("Overrides"), new WebInspector.UserAgentSettingsTab());

You also need to chance these in the WebCore/English.lproj/localizedStrings.js

[Addy Osmani]

Created attachment 156130 [details]
Patch

[Addy Osmani]

(In reply to comment #2)
> (From update of attachment 156088 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=156088&action=review
> 
> > Source/WebCore/inspector/front-end/SettingsScreen.js:48
> > +    this._tabbedPane.appendTab(WebInspector.SettingsScreen.Tabs.UserAgent, WebInspector.UIString("Overrides"), new WebInspector.UserAgentSettingsTab());
> 
> You also need to chance these in the WebCore/English.lproj/localizedStrings.js

Done!

[Addy Osmani]

Created attachment 156132 [details]
Patch

[WebKit Review Bot]

Comment on attachment 156132 [details]
Patch

Clearing flags on attachment: 156132

Committed r124486: <http://trac.webkit.org/changeset/124486>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.