Bug 92990 - Web Inspector: Rename 'User agent' to 'Overrides' in settings screen
Summary: Web Inspector: Rename 'User agent' to 'Overrides' in settings screen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Addy Osmani
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-02 07:30 PDT by Addy Osmani
Modified: 2012-08-02 12:42 PDT (History)
11 users (show)

See Also:


Attachments
Patch (3.31 KB, patch)
2012-08-02 08:11 PDT, Addy Osmani
no flags Details | Formatted Diff | Diff
Patch (4.62 KB, patch)
2012-08-02 11:30 PDT, Addy Osmani
no flags Details | Formatted Diff | Diff
Patch (5.09 KB, patch)
2012-08-02 11:59 PDT, Addy Osmani
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Addy Osmani 2012-08-02 07:30:11 PDT
As the User agent tab in the settings screen has evolved over time to include override capabilities for more than just the user agent, I think we should rename this to 'Overrides', which better describes what the tab contains.
Comment 1 Addy Osmani 2012-08-02 08:11:54 PDT
Created attachment 156088 [details]
Patch
Comment 2 Pavel Feldman 2012-08-02 10:59:02 PDT
Comment on attachment 156088 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156088&action=review

> Source/WebCore/inspector/front-end/SettingsScreen.js:48
> +    this._tabbedPane.appendTab(WebInspector.SettingsScreen.Tabs.UserAgent, WebInspector.UIString("Overrides"), new WebInspector.UserAgentSettingsTab());

You also need to chance these in the WebCore/English.lproj/localizedStrings.js
Comment 3 Addy Osmani 2012-08-02 11:30:58 PDT
Created attachment 156130 [details]
Patch
Comment 4 Addy Osmani 2012-08-02 11:36:17 PDT

(In reply to comment #2)
> (From update of attachment 156088 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=156088&action=review
> 
> > Source/WebCore/inspector/front-end/SettingsScreen.js:48
> > +    this._tabbedPane.appendTab(WebInspector.SettingsScreen.Tabs.UserAgent, WebInspector.UIString("Overrides"), new WebInspector.UserAgentSettingsTab());
> 
> You also need to chance these in the WebCore/English.lproj/localizedStrings.js

Done!
Comment 5 Addy Osmani 2012-08-02 11:59:16 PDT
Created attachment 156132 [details]
Patch
Comment 6 WebKit Review Bot 2012-08-02 12:42:18 PDT
Comment on attachment 156132 [details]
Patch

Clearing flags on attachment: 156132

Committed r124486: <http://trac.webkit.org/changeset/124486>
Comment 7 WebKit Review Bot 2012-08-02 12:42:22 PDT
All reviewed patches have been landed.  Closing bug.