Bug 92983 - [CSS Regions] Implement the getRegions() API and add the Region interface methods on Element
Summary: [CSS Regions] Implement the getRegions() API and add the Region interface met...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 93240 93256
Blocks: 92089
  Show dependency treegraph
 
Reported: 2012-08-02 06:33 PDT by Andrei Bucur
Modified: 2012-08-06 08:37 PDT (History)
6 users (show)

See Also:


Attachments
Patch (41.03 KB, patch)
2012-08-02 09:03 PDT, Andrei Bucur
no flags Details | Formatted Diff | Diff
Patch (40.97 KB, patch)
2012-08-02 09:31 PDT, Andrei Bucur
no flags Details | Formatted Diff | Diff
Patch (41.08 KB, patch)
2012-08-02 09:53 PDT, Andrei Bucur
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-06 (546.04 KB, application/zip)
2012-08-02 11:08 PDT, WebKit Review Bot
no flags Details
Patch (40.58 KB, patch)
2012-08-03 05:15 PDT, Andrei Bucur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Bucur 2012-08-02 06:33:23 PDT
The Region supplemental interface implementation is postponed until another type of container is available. For now, move the Region members on Element and implement them there.
Comment 1 Andrei Bucur 2012-08-02 09:03:47 PDT
Created attachment 156102 [details]
Patch
Comment 2 Andrei Bucur 2012-08-02 09:31:56 PDT
Created attachment 156108 [details]
Patch
Comment 3 Andrei Bucur 2012-08-02 09:53:22 PDT
Created attachment 156112 [details]
Patch
Comment 4 WebKit Review Bot 2012-08-02 11:08:26 PDT
Comment on attachment 156112 [details]
Patch

Attachment 156112 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13404885

New failing tests:
svg/custom/detached-outermost-svg-crash.html
fast/dom/domListEnumeration.html
fast/dom/plugin-attributes-enumeration.html
Comment 5 WebKit Review Bot 2012-08-02 11:08:30 PDT
Created attachment 156126 [details]
Archive of layout-test-results from gce-cr-linux-06

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 6 Andrei Bucur 2012-08-03 05:15:30 PDT
Created attachment 156333 [details]
Patch
Comment 7 Adam Barth 2012-08-03 10:36:43 PDT
Comment on attachment 156333 [details]
Patch

LGTM.  If possible, I'd prefer if someone else gave the official r+ because there's a bunch of regions details in here that I don't fully understand.
Comment 8 Andrei Bucur 2012-08-06 05:48:36 PDT
I've broken the patch in two parts:
b93240 -> Add the getRegions() API call
b93256 -> Rename regionOverflow to regionOverset