Bug 92978 - [Qt] MSVC specific buildfix for DRT.
Summary: [Qt] MSVC specific buildfix for DRT.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-02 05:08 PDT by Zoltan Arvai
Modified: 2012-08-02 06:13 PDT (History)
4 users (show)

See Also:

Attachments
drt-fix-msvc (1.04 KB, patch)
2012-08-02 05:09 PDT, Zoltan Arvai 		no flags Details | Formatted Diff | Diff
drt-fix-msvc (1.06 KB, patch)
2012-08-02 05:22 PDT, Zoltan Arvai 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Arvai 2012-08-02 05:08:16 PDT 
Include for DumpRenderTree/qt subdirectory is missing from generated makefile under MSVC build. It's need to be added to DumpRenderTree.pro file.
Comment 1 Zoltan Arvai 2012-08-02 05:09:18 PDT 
Created attachment 156042 [details]
drt-fix-msvc
Comment 2 Csaba Osztrogonác 2012-08-02 05:15:59 PDT 
Comment on attachment 156042 [details]
drt-fix-msvc

View in context: https://bugs.webkit.org/attachment.cgi?id=156042&action=review

> Tools/ChangeLog:4
> +        Need the bug URL (OOPS!).

^^^^^^
Comment 3 Zoltan Arvai 2012-08-02 05:22:11 PDT 
Created attachment 156044 [details]
drt-fix-msvc

Adding missing bug url to patch. Sorry.
Comment 4 Balazs Kelemen 2012-08-02 05:35:39 PDT 
It's strange that on Linux the directory where the pro file exists added by default but on Windows it doesn't. Isn't it a qmake bug?
Comment 5 WebKit Review Bot 2012-08-02 06:13:48 PDT 
Comment on attachment 156044 [details]
drt-fix-msvc

Clearing flags on attachment: 156044

Committed r124447: <http://trac.webkit.org/changeset/124447>
Comment 6 WebKit Review Bot 2012-08-02 06:13:52 PDT 
All reviewed patches have been landed.  Closing bug.