Bug 92962 - Web Inspector: add CSSRule memory instrumentation
Summary: Web Inspector: add CSSRule memory instrumentation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on: 92748
Blocks: 87262
  Show dependency treegraph
 
Reported: 2012-08-02 02:12 PDT by Yury Semikhatsky
Modified: 2012-08-03 03:18 PDT (History)
18 users (show)

See Also:


Attachments
Patch (29.81 KB, patch)
2012-08-02 02:25 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch (29.74 KB, patch)
2012-08-02 03:34 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-08-02 02:12:15 PDT
It is the next step required for reporting memory footprint for CSSStyleSheet and related objects.
Comment 1 Yury Semikhatsky 2012-08-02 02:25:13 PDT
Created attachment 156018 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-08-02 03:26:35 PDT
Comment on attachment 156018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156018&action=review

lgtm with nits

> Source/WebCore/css/CSSRuleList.h:36
> +class MemoryObjectInfo;

unnecessary line
Comment 3 Yury Semikhatsky 2012-08-02 03:33:16 PDT
Comment on attachment 156018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156018&action=review

>> Source/WebCore/css/CSSRuleList.h:36
>> +class MemoryObjectInfo;
> 
> unnecessary line

Removed.
Comment 4 Yury Semikhatsky 2012-08-02 03:34:40 PDT
Created attachment 156026 [details]
Patch
Comment 5 WebKit Review Bot 2012-08-03 03:18:47 PDT
Comment on attachment 156026 [details]
Patch

Clearing flags on attachment: 156026

Committed r124589: <http://trac.webkit.org/changeset/124589>
Comment 6 WebKit Review Bot 2012-08-03 03:18:54 PDT
All reviewed patches have been landed.  Closing bug.