Bug 92943 - [EFL] Crash while loading plugin after r121467
Summary: [EFL] Crash while loading plugin after r121467
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-01 22:20 PDT by Ryuan Choi
Modified: 2012-08-02 18:55 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.06 KB, patch)
2012-08-01 22:39 PDT, Ryuan Choi
no flags Details | Formatted Diff | Diff
Patch (2.04 KB, patch)
2012-08-02 16:46 PDT, Ryuan Choi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2012-08-01 22:20:01 PDT
r121467 introduced eina_module instead of dlopen.
but some codes using dlsym are remaind.
So EWebLauncher is crashed while loading plugin when enabled netscape plugin api.
Comment 1 Ryuan Choi 2012-08-01 22:39:22 PDT
Created attachment 155976 [details]
Patch
Comment 2 Laszlo Gombos 2012-08-02 13:38:37 PDT
Comment on attachment 155976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155976&action=review

> Source/WebCore/ChangeLog:8
> +        r121468 replaced POSIX dlopen to helpers in eina_module, but some codes

Nit - should this be 121467 instead of 121468.
Comment 3 Chris Dumez 2012-08-02 13:45:15 PDT
Comment on attachment 155976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155976&action=review

LGTM but:

>> Source/WebCore/ChangeLog:8
>> +        r121468 replaced POSIX dlopen to helpers in eina_module, but some codes
> 
> Nit - should this be 121467 instead of 121468.

Yes, Laszlo is right, definitely http://trac.webkit.org/changeset/121467
Comment 4 Ryuan Choi 2012-08-02 16:46:29 PDT
Created attachment 156203 [details]
Patch
Comment 5 Ryuan Choi 2012-08-02 16:47:47 PDT
(In reply to comment #2)
> (From update of attachment 155976 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=155976&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        r121468 replaced POSIX dlopen to helpers in eina_module, but some codes
> 
> Nit - should this be 121467 instead of 121468.

Oops, my mistake, fixed.
Comment 6 Laszlo Gombos 2012-08-02 17:49:09 PDT
Comment on attachment 156203 [details]
Patch

r=me. Thanks.
Comment 7 WebKit Review Bot 2012-08-02 18:55:06 PDT
Comment on attachment 156203 [details]
Patch

Clearing flags on attachment: 156203

Committed r124548: <http://trac.webkit.org/changeset/124548>
Comment 8 WebKit Review Bot 2012-08-02 18:55:11 PDT
All reviewed patches have been landed.  Closing bug.