Bug 92942 – Add DeviceProximityEvent interface

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Kihong Kwon]

Add DeviceProximityEvent interface.
And add onwebkitdeviceproximity event handler to the DOMWindow.

[Kihong Kwon]

Created attachment 155981 [details]
Patch

[Kihong Kwon]

Created attachment 155985 [details]
Patch

[Adam Barth]

Looks like the spec is here:
http://www.w3.org/TR/proximity/#idl-def-DeviceProximityEvent

[Kentaro Hara]

Comment on attachment 155985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155985&action=review

WebCore implementation looks good. Marking r- due to insufficient tests.

> Source/WebCore/ChangeLog:9
> +        Add DeviceProximityEvent interface of Proximity Events.
> +        And add onwebkitdeviceproximity event handler to the DOMWindow.

Please add the spec link to the ChangeLog.

> Source/WebCore/Modules/proximity/DeviceProximityEvent.h:45
> +        return adoptRef(new DeviceProximityEvent);

Nit: new DeviceProximityEvent()

> LayoutTests/ChangeLog:8
> +        Add a test case to create DeviceProximityEvent and to check onwebkitdeviceproximity.

- Let's add test cases for constructor. Look at tests under fast/events/constructors/. Let's add fast/events/constructors/device-proximity-event.html

- Can you test if the DeviceProximityEvent bubbles up correctly?

[Kihong Kwon]

Created attachment 156618 [details]
Patch

[Kihong Kwon]

Comment on attachment 155985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155985&action=review

>> Source/WebCore/Modules/proximity/DeviceProximityEvent.h:45
>> +        return adoptRef(new DeviceProximityEvent);
> 
> Nit: new DeviceProximityEvent()

OK.

>> LayoutTests/ChangeLog:8
>> +        Add a test case to create DeviceProximityEvent and to check onwebkitdeviceproximity.
> 
> - Let's add test cases for constructor. Look at tests under fast/events/constructors/. Let's add fast/events/constructors/device-proximity-event.html
> 
> - Can you test if the DeviceProximityEvent bubbles up correctly?

OK, I added a test case for constructor.

[Kentaro Hara]

Comment on attachment 156618 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156618&action=review

> LayoutTests/fast/dom/Proximity/check-event-deviceproximity.html:9
> +<script src="script-tests/check-event-deviceproximity.js"></script>

Nit: You can directly write JavaScript here.

> LayoutTests/fast/dom/Proximity/create-event-deviceproximity.html:9
> +<script src="script-tests/create-event-deviceproximity.js"></script>

Ditto.

> LayoutTests/fast/events/constructors/device-proximity-event-constructor.html:14
> +shouldBe("new DeviceProximityEvent('eventType').bubbles", "false");

Isn't this true?

[Kihong Kwon]

Created attachment 156632 [details]
Patch

[Kihong Kwon]

Comment on attachment 156618 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156618&action=review

>> LayoutTests/fast/dom/Proximity/check-event-deviceproximity.html:9
>> +<script src="script-tests/check-event-deviceproximity.js"></script>
> 
> Nit: You can directly write JavaScript here.

Changed it.

>> LayoutTests/fast/dom/Proximity/create-event-deviceproximity.html:9
>> +<script src="script-tests/create-event-deviceproximity.js"></script>
> 
> Ditto.

ditto.

>> LayoutTests/fast/events/constructors/device-proximity-event-constructor.html:14
>> +shouldBe("new DeviceProximityEvent('eventType').bubbles", "false");
> 
> Isn't this true?

You are right.
It's fixed.

[Kentaro Hara]

Comment on attachment 156632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156632&action=review

Looks OK.

Sorry for the iterative comments. A couple of nits in your test.

> LayoutTests/fast/dom/Proximity/create-event-deviceproximity.html:14
> +    document.getElementById('result').innerHTML = "PASS";

Nit: you could use testPassed()

> LayoutTests/fast/dom/Proximity/create-event-deviceproximity.html:24
> +    document.getElementById('result').innerHTML = "FAIL... deviceproximity event doesn't appear to be enabled or implemented.";

Nit: you could use testFailed()

[Kihong Kwon]

Comment on attachment 156632 [details]
Patch

No problem. Thank you :)

[Kihong Kwon]

Created attachment 156640 [details]
patch for landing.

[WebKit Review Bot]

Comment on attachment 156632 [details]
Patch

Attachment 156632 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13447242

New failing tests:
fast/events/constructors/device-proximity-event-constructor.html

[WebKit Review Bot]

Created attachment 156648 [details]
Archive of layout-test-results from gce-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Kihong Kwon]

Created attachment 156652 [details]
patch for landing.

[WebKit Review Bot]

Comment on attachment 156652 [details]
patch for landing.

Clearing flags on attachment: 156652

Committed r124759: <http://trac.webkit.org/changeset/124759>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Lucas Forschler]

Mass move bugs into the DOM component.