Bug 92940 - StringImpl created from literal should be BufferInternal
Summary: StringImpl created from literal should be BufferInternal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on: 145120
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-01 22:03 PDT by Benjamin Poulain
Modified: 2015-05-18 02:28 PDT (History)
5 users (show)

See Also:

Attachments
Patch (18.58 KB, patch)
2012-08-01 22:39 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (21.22 KB, patch)
2012-08-02 14:57 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (20.53 KB, patch)
2012-08-02 16:06 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-08-01 22:03:05 PDT 
I made a last minute change that caused createFromLiteral() to use BufferOwned instead of BufferInternal.

On destruction, such strings are trying to delete the read only char* string.
Comment 1 Benjamin Poulain 2012-08-01 22:39:10 PDT 
Created attachment 155975 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-01 22:40:43 PDT 
Attachment 155975 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/te..." exit_code: 1
Tools/TestWebKitAPI/Tests/WTF/AtomicString.cpp:36:  Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b)  [readability/check] [2]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Benjamin Poulain 2012-08-01 22:42:24 PDT 
> Tools/TestWebKitAPI/Tests/WTF/AtomicString.cpp:36:  Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b)  [readability/check] [2]

This is expected.
I did not change that because ASSERT_EQ does not use our operator==.
Comment 4 Gyuyoung Kim 2012-08-01 23:57:57 PDT 
Comment on attachment 155975 [details]
Patch

Attachment 155975 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13411769
Comment 5 Benjamin Poulain 2012-08-02 14:57:23 PDT 
Created attachment 156176 [details]
Patch
Comment 6 WebKit Review Bot 2012-08-02 15:00:43 PDT 
Attachment 156176 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/te..." exit_code: 1
Tools/TestWebKitAPI/Tests/WTF/AtomicString.cpp:36:  Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b)  [readability/check] [2]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Build Bot 2012-08-02 15:50:37 PDT 
Comment on attachment 156176 [details]
Patch

Attachment 156176 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13404972
Comment 8 Benjamin Poulain 2012-08-02 16:06:40 PDT 
Created attachment 156191 [details]
Patch
Comment 9 WebKit Review Bot 2012-08-02 16:10:05 PDT 
Attachment 156191 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/te..." exit_code: 1
Tools/TestWebKitAPI/Tests/WTF/AtomicString.cpp:36:  Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b)  [readability/check] [2]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Benjamin Poulain 2012-08-03 07:37:42 PDT 
Comment on attachment 156191 [details]
Patch

Clearing flags on attachment: 156191

Committed r124611: <http://trac.webkit.org/changeset/124611>
Comment 11 Benjamin Poulain 2012-08-03 07:37:46 PDT 
All reviewed patches have been landed.  Closing bug.