Bug 92936 - Fix typo in colorSuggestionPicker.js
Summary: Fix typo in colorSuggestionPicker.js
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-01 20:46 PDT by Keishi Hattori
Modified: 2012-08-01 22:30 PDT (History)
2 users (show)

See Also:

Attachments
Patch (11.59 KB, patch)
2012-08-01 20:49 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (16.42 KB, patch)
2012-08-01 21:04 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (11.25 KB, patch)
2012-08-01 21:12 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (11.25 KB, patch)
2012-08-01 21:42 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-08-01 20:46:50 PDT 
Fix typo in colorSuggestionPicker.js
Comment 1 Keishi Hattori 2012-08-01 20:49:45 PDT 
Created attachment 155961 [details]
Patch
Comment 2 Kent Tamura 2012-08-01 20:53:52 PDT 
Comment on attachment 155961 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155961&action=review

> LayoutTests/platform/chromium/TestExpectations:3337
> +BUGWK92444 : platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html = PASS MISSING TEXT

IMAGE is necessary for chromium-mac-snowleopard.

> LayoutTests/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.txt:2
> +CONSOLE MESSAGE: line 107: Check if window.pagePopupController exists for a page-popup window.
> +CONSOLE MESSAGE: line 118: [object PagePopupController]

This check is out of scope of the test, isn't it?
Comment 3 Keishi Hattori 2012-08-01 21:04:39 PDT 
Created attachment 155966 [details]
Patch
Comment 4 Kent Tamura 2012-08-01 21:06:34 PDT 
Comment on attachment 155966 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155966&action=review

> LayoutTests/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.txt:1
> +layer at (0,0) size 800x600

nit: If you are not interested in a render tree dump, testRunner.dumpAsText(true) is ok.
Comment 5 Keishi Hattori 2012-08-01 21:12:30 PDT 
Created attachment 155968 [details]
Patch
Comment 6 WebKit Review Bot 2012-08-01 21:18:28 PDT 
Comment on attachment 155968 [details]
Patch

Rejecting attachment 155968 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13423240
Comment 7 Keishi Hattori 2012-08-01 21:42:24 PDT 
Created attachment 155970 [details]
Patch
Comment 8 WebKit Review Bot 2012-08-01 22:30:13 PDT 
Comment on attachment 155970 [details]
Patch

Clearing flags on attachment: 155970

Committed r124409: <http://trac.webkit.org/changeset/124409>
Comment 9 WebKit Review Bot 2012-08-01 22:30:17 PDT 
All reviewed patches have been landed.  Closing bug.