Bug 92935 - Remove all uses of ClassInfo for JSStrings in JIT code
Summary: Remove all uses of ClassInfo for JSStrings in JIT code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-01 20:00 PDT by Mark Hahnenberg
Modified: 2012-08-02 10:32 PDT (History)
2 users (show)

See Also:


Attachments
Patch (21.74 KB, patch)
2012-08-01 20:09 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff
Patch (21.73 KB, patch)
2012-08-01 20:19 PDT, Mark Hahnenberg
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-08-01 20:00:55 PDT
Patch forthcoming.
Comment 1 Mark Hahnenberg 2012-08-01 20:09:06 PDT
Created attachment 155956 [details]
Patch
Comment 2 Early Warning System Bot 2012-08-01 20:13:41 PDT
Comment on attachment 155956 [details]
Patch

Attachment 155956 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13426029
Comment 3 Early Warning System Bot 2012-08-01 20:15:01 PDT
Comment on attachment 155956 [details]
Patch

Attachment 155956 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13425052
Comment 4 Mark Hahnenberg 2012-08-01 20:19:57 PDT
Created attachment 155958 [details]
Patch
Comment 5 Geoffrey Garen 2012-08-01 21:50:29 PDT
Comment on attachment 155958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155958&action=review

r=me

> Source/JavaScriptCore/bytecode/SpeculatedType.cpp:270
> +    if (structure->typeInfo().type() == StringType)
> +        return SpecString;

FWIW, you *could* get the JSGlobalData from structure->globalObject()->globalData().
Comment 6 Mark Hahnenberg 2012-08-02 10:32:50 PDT
Committed r124476: <http://trac.webkit.org/changeset/124476>