RESOLVED FIXED 92924
[chromium] Move compositor HUD font atlas initialization code out of compositor core 
https://bugs.webkit.org/show_bug.cgi?id=92924
Summary [chromium] Move compositor HUD font atlas initialization code out of composit...
James Robinson
Reported 2012-08-01 17:11:36 PDT
[chromium] Move compositor HUD font atlas initialization code out of compositor core
Attachments
Patch (23.93 KB, patch)
2012-08-01 17:15 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
fix trace and unit test (24.74 KB, patch)
2012-08-01 17:55 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
remove unnecessary include of CompositorHUDFontAtlas.h (24.56 KB, patch)
2012-08-01 18:00 PDT, James Robinson 		enne: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-08-01 17:15:34 PDT
Created attachment 155930 [details] Patch
WebKit Review Bot
Comment 2 2012-08-01 17:17:04 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 3 2012-08-01 17:23:43 PDT
Comment on attachment 155930 [details] Patch Attachment 155930 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13415384
James Robinson
Comment 4 2012-08-01 17:31:53 PDT
Whoops, forgot to fix some unit tests. Will update the patch.
Adrienne Walker
Comment 5 2012-08-01 17:42:55 PDT
View in context: https://bugs.webkit.org/attachment.cgi?id=155930&action=review Looks good in general. > Source/WebKit/chromium/src/WebViewImpl.cpp:3675 > + TRACE_EVENT0("cc", "HeadsUpDisplayLayerChromium::initializeFontAtlas"); Out of date.
James Robinson
Comment 6 2012-08-01 17:55:39 PDT
Created attachment 155937 [details] fix trace and unit test
Adrienne Walker
Comment 7 2012-08-01 17:57:57 PDT
Comment on attachment 155937 [details] fix trace and unit test R=me.
James Robinson
Comment 8 2012-08-01 18:00:26 PDT
Created attachment 155938 [details] remove unnecessary include of CompositorHUDFontAtlas.h
Adrienne Walker
Comment 9 2012-08-01 18:07:20 PDT
Comment on attachment 155938 [details] remove unnecessary include of CompositorHUDFontAtlas.h R=me.
James Robinson
Comment 10 2012-08-01 18:18:57 PDT
Committed r124396: <http://trac.webkit.org/changeset/124396>
Note You need to log in before you can comment on or make changes to this bug.