Bug 92924 - [chromium] Move compositor HUD font atlas initialization code out of compositor core
Summary: [chromium] Move compositor HUD font atlas initialization code out of composit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-01 17:11 PDT by James Robinson
Modified: 2012-08-01 18:18 PDT (History)
7 users (show)

See Also:

Attachments
Patch (23.93 KB, patch)
2012-08-01 17:15 PDT, James Robinson 		no flags Details | Formatted Diff | Diff
fix trace and unit test (24.74 KB, patch)
2012-08-01 17:55 PDT, James Robinson 		no flags Details | Formatted Diff | Diff
remove unnecessary include of CompositorHUDFontAtlas.h (24.56 KB, patch)
2012-08-01 18:00 PDT, James Robinson 		enne: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-08-01 17:11:36 PDT 
[chromium] Move compositor HUD font atlas initialization code out of compositor core
Comment 1 James Robinson 2012-08-01 17:15:34 PDT 
Created attachment 155930 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-01 17:17:04 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2012-08-01 17:23:43 PDT 
Comment on attachment 155930 [details]
Patch

Attachment 155930 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13415384
Comment 4 James Robinson 2012-08-01 17:31:53 PDT 
Whoops, forgot to fix some unit tests.  Will update the patch.
Comment 5 Adrienne Walker 2012-08-01 17:42:55 PDT 
View in context: https://bugs.webkit.org/attachment.cgi?id=155930&action=review

Looks good in general.

> Source/WebKit/chromium/src/WebViewImpl.cpp:3675
> +                TRACE_EVENT0("cc", "HeadsUpDisplayLayerChromium::initializeFontAtlas");

Out of date.
Comment 6 James Robinson 2012-08-01 17:55:39 PDT 
Created attachment 155937 [details]
fix trace and unit test
Comment 7 Adrienne Walker 2012-08-01 17:57:57 PDT 
Comment on attachment 155937 [details]
fix trace and unit test

R=me.
Comment 8 James Robinson 2012-08-01 18:00:26 PDT 
Created attachment 155938 [details]
remove unnecessary include of CompositorHUDFontAtlas.h
Comment 9 Adrienne Walker 2012-08-01 18:07:20 PDT 
Comment on attachment 155938 [details]
remove unnecessary include of CompositorHUDFontAtlas.h

R=me.
Comment 10 James Robinson 2012-08-01 18:18:57 PDT 
Committed r124396: <http://trac.webkit.org/changeset/124396>