Bug 92912 - Generalize SheriffIRCBot to prepare for PerfBot
Summary: Generalize SheriffIRCBot to prepare for PerfBot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 92913
  Show dependency tree / graph
 
Reported: 2012-08-01 15:03 PDT by Ryosuke Niwa
Modified: 2012-08-01 18:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (39.31 KB, patch)
2012-08-01 15:07 PDT, Ryosuke Niwa 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-08-01 15:03:14 PDT 
Generalize SheriffIRCBot to prepare for PerfBot
Comment 1 Ryosuke Niwa 2012-08-01 15:07:53 PDT 
Created attachment 155896 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-01 15:10:31 PDT 
Attachment 155896 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1
Tools/Scripts/webkitpy/tool/bot/ircbot_unittest.py:6:  trailing whitespace  [pep8/W291] [5]
Tools/Scripts/webkitpy/tool/bot/ircbot_unittest.py:16:  trailing whitespace  [pep8/W291] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Barth 2012-08-01 15:12:50 PDT 
Thank you.  I've wanted to do that for ages.
Comment 4 Ryosuke Niwa 2012-08-01 15:16:15 PDT 
Committed r124373: <http://trac.webkit.org/changeset/124373>
Comment 5 Dirk Pranke 2012-08-01 18:00:30 PDT 
what do you imagine a PerfBot will do?
Comment 6 Ryosuke Niwa 2012-08-01 18:03:36 PDT 
(In reply to comment #5)
> what do you imagine a PerfBot will do?

I'll run performance tests as asked on IRC and report the results.