Bug 92889 – [BlackBerry] Implement InRegionScroller class as a in-region scroll controller

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Antonio Gomes]

From PR 186587:

Class will:
1) Centralize all in-region scrolling logic, cleaning up WebPage{Private}
2) Be the base to scroll in-region content from UI/Compositing thread.

[Antonio Gomes]

Created attachment 155895 [details]
patch

[WebKit Review Bot]

Attachment 155895 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/..." exit_code: 1
Source/WebKit/blackberry/WebKitSupport/InRegionScroller.cpp:24:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/blackberry/Api/WebPage.cpp:2638:  More than one command on the same line  [whitespace/newline] [4]
Source/WebKit/blackberry/Api/WebPage_p.h:25:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Arvid Nilsson]

Comment on attachment 155895 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155895&action=review

Cool!

> Source/WebKit/blackberry/WebKitSupport/InRegionScroller.cpp:145
> +    return !m_inRegionScrollStartingNode;

Looking at the implementation and usage, would it make sense to rename this "canScroll()" and change if (!scroller->isNull()) to if (scroller->canScroll()) ?

I am thinking the scroller itself is never null, it lives as long as the web page, so name a bit misleading.

> Source/WebKit/blackberry/WebKitSupport/InRegionScroller.h:46
> +    bool isNull() const;

Would it make sense to rename this, maybe hasNode() or

[Antonio Gomes]

Created attachment 156091 [details]
patch v2

Fixed style issues and Arvid's API suggestions.

[WebKit Review Bot]

Attachment 156091 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/..." exit_code: 1
Source/WebKit/blackberry/Api/WebPage.cpp:2638:  More than one command on the same line  [whitespace/newline] [4]
Source/WebKit/blackberry/Api/WebPage_p.h:25:  "InspectorOverlay.h" already included at Source/WebKit/blackberry/Api/WebPage_p.h:24  [build/include] [4]
Source/WebKit/blackberry/Api/WebPage_p.h:25:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antonio Gomes]

Created attachment 156094 [details]
patch v3

One more style issue fixed

[WebKit Review Bot]

Attachment 156094 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/..." exit_code: 1
Source/WebKit/blackberry/Api/WebPage_p.h:25:  "InspectorOverlay.h" already included at Source/WebKit/blackberry/Api/WebPage_p.h:24  [build/include] [4]
Source/WebKit/blackberry/Api/WebPage_p.h:25:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antonio Gomes]

Created attachment 156098 [details]
(committed r124470, r=yoli) patch v4

Another style issue fixed

[Arvid Nilsson]

Comment on attachment 156091 [details]
patch v2

Looks good to me :)

[Yong Li]

Comment on attachment 156098 [details]
(committed r124470, r=yoli) patch v4

r+

[Antonio Gomes]

Comment on attachment 156098 [details]
(committed r124470, r=yoli) patch v4

<http://trac.webkit.org/changeset/124470>

[Antonio Gomes]

.

[Antonio Gomes]

Created attachment 156140 [details]
debug build fix

[WebKit Review Bot]

Comment on attachment 156140 [details]
debug build fix

Clearing flags on attachment: 156140

Committed r124488: <http://trac.webkit.org/changeset/124488>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.