Bug 92889 - [BlackBerry] Implement InRegionScroller class as a in-region scroll controller
Summary: [BlackBerry] Implement InRegionScroller class as a in-region scroll controller
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-01 11:00 PDT by Antonio Gomes
Modified: 2012-08-02 13:23 PDT (History)
6 users (show)

See Also:


Attachments
patch (40.75 KB, patch)
2012-08-01 15:05 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff
patch v2 (40.89 KB, patch)
2012-08-02 08:19 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff
patch v3 (40.89 KB, patch)
2012-08-02 08:31 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff
(committed r124470, r=yoli) patch v4 (40.83 KB, patch)
2012-08-02 08:39 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff
debug build fix (1.98 KB, patch)
2012-08-02 12:30 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2012-08-01 11:00:06 PDT
From PR 186587:

Class will:
1) Centralize all in-region scrolling logic, cleaning up WebPage{Private}
2) Be the base to scroll in-region content from UI/Compositing thread.
Comment 1 Antonio Gomes 2012-08-01 15:05:39 PDT
Created attachment 155895 [details]
patch
Comment 2 WebKit Review Bot 2012-08-01 15:08:59 PDT
Attachment 155895 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/..." exit_code: 1
Source/WebKit/blackberry/WebKitSupport/InRegionScroller.cpp:24:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/blackberry/Api/WebPage.cpp:2638:  More than one command on the same line  [whitespace/newline] [4]
Source/WebKit/blackberry/Api/WebPage_p.h:25:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Arvid Nilsson 2012-08-01 21:45:31 PDT
Comment on attachment 155895 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155895&action=review

Cool!

> Source/WebKit/blackberry/WebKitSupport/InRegionScroller.cpp:145
> +    return !m_inRegionScrollStartingNode;

Looking at the implementation and usage, would it make sense to rename this "canScroll()" and change if (!scroller->isNull()) to if (scroller->canScroll()) ?

I am thinking the scroller itself is never null, it lives as long as the web page, so name a bit misleading.

> Source/WebKit/blackberry/WebKitSupport/InRegionScroller.h:46
> +    bool isNull() const;

Would it make sense to rename this, maybe hasNode() or
Comment 4 Antonio Gomes 2012-08-02 08:19:59 PDT
Created attachment 156091 [details]
patch v2

Fixed style issues and Arvid's API suggestions.
Comment 5 WebKit Review Bot 2012-08-02 08:24:36 PDT
Attachment 156091 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/..." exit_code: 1
Source/WebKit/blackberry/Api/WebPage.cpp:2638:  More than one command on the same line  [whitespace/newline] [4]
Source/WebKit/blackberry/Api/WebPage_p.h:25:  "InspectorOverlay.h" already included at Source/WebKit/blackberry/Api/WebPage_p.h:24  [build/include] [4]
Source/WebKit/blackberry/Api/WebPage_p.h:25:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Antonio Gomes 2012-08-02 08:31:21 PDT
Created attachment 156094 [details]
patch v3

One more style issue fixed
Comment 7 WebKit Review Bot 2012-08-02 08:33:55 PDT
Attachment 156094 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/..." exit_code: 1
Source/WebKit/blackberry/Api/WebPage_p.h:25:  "InspectorOverlay.h" already included at Source/WebKit/blackberry/Api/WebPage_p.h:24  [build/include] [4]
Source/WebKit/blackberry/Api/WebPage_p.h:25:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Antonio Gomes 2012-08-02 08:39:21 PDT
Created attachment 156098 [details]
(committed r124470, r=yoli) patch v4

Another style issue fixed
Comment 9 Arvid Nilsson 2012-08-02 08:39:22 PDT
Comment on attachment 156091 [details]
patch v2

Looks good to me :)
Comment 10 Yong Li 2012-08-02 08:50:21 PDT
Comment on attachment 156098 [details]
(committed r124470, r=yoli) patch v4

r+
Comment 11 Antonio Gomes 2012-08-02 09:43:33 PDT
Comment on attachment 156098 [details]
(committed r124470, r=yoli) patch v4

<http://trac.webkit.org/changeset/124470>
Comment 12 Antonio Gomes 2012-08-02 12:30:00 PDT
.
Comment 13 Antonio Gomes 2012-08-02 12:30:32 PDT
Created attachment 156140 [details]
debug build fix
Comment 14 WebKit Review Bot 2012-08-02 13:23:32 PDT
Comment on attachment 156140 [details]
debug build fix

Clearing flags on attachment: 156140

Committed r124488: <http://trac.webkit.org/changeset/124488>
Comment 15 WebKit Review Bot 2012-08-02 13:23:37 PDT
All reviewed patches have been landed.  Closing bug.