Bug 92887 - run-perf-tests throws an exception when the output json is malformed
Summary: run-perf-tests throws an exception when the output json is malformed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 77037
  Show dependency tree / graph
 
Reported: 2012-08-01 10:49 PDT by Ryosuke Niwa
Modified: 2012-08-01 11:23 PDT (History)
2 users (show)

See Also:

Attachments
Patch (13.92 KB, patch)
2012-08-01 10:58 PDT, Ryosuke Niwa 		dpranke: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-08-01 10:49:02 PDT 
run-perf-tests throws an exception when the output json is malformed
Comment 1 Ryosuke Niwa 2012-08-01 10:58:23 PDT 
Created attachment 155843 [details]
Patch
Comment 2 Dirk Pranke 2012-08-01 11:03:21 PDT 
Comment on attachment 155843 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155843&action=review

> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:56
> +    _EXIT_CODE_BAD_PREPARATION = -5

Nit: the leading underscore makes these look like they're supposed to be private, but you return them from run(); should they be public (and have no leading underscore)?
Comment 3 Ryosuke Niwa 2012-08-01 11:20:15 PDT 
(In reply to comment #2)
> (From update of attachment 155843 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=155843&action=review
> 
> > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:56
> > +    _EXIT_CODE_BAD_PREPARATION = -5
> 
> Nit: the leading underscore makes these look like they're supposed to be private, but you return them from run(); should they be public (and have no leading underscore)?

Yeah, I should get rid of underscores. Will do. Thanks.
Comment 4 Ryosuke Niwa 2012-08-01 11:23:32 PDT 
Committed r124349: <http://trac.webkit.org/changeset/124349>