Bug 92886 - Enable codec tests in TestExpectations and update expected mp3 files
Summary: Enable codec tests in TestExpectations and update expected mp3 files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raymond Toy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-01 10:48 PDT by Raymond Toy
Modified: 2012-08-01 17:16 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.82 KB, patch)
2012-08-01 11:31 PDT, Raymond Toy 		no flags Details | Formatted Diff | Diff
Patch (4.98 KB, patch)
2012-08-01 13:50 PDT, Raymond Toy 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raymond Toy 2012-08-01 10:48:09 PDT 
The infrastructure should be in place to enable the test for the proprietary codecs.  If DRT doesn't support the codecs, the tests should be automatically skipped.

Also, the recent ffmpeg roll that adds support for removing the pre-roll samples from (some) mp3 files changes the expected results for the mp3 codec tests.  These need to be updated.
Comment 1 Raymond Toy 2012-08-01 11:31:55 PDT 
Created attachment 155846 [details]
Patch
Comment 2 Raymond Toy 2012-08-01 13:50:39 PDT 
Created attachment 155877 [details]
Patch
Comment 3 Chris Rogers 2012-08-01 15:55:40 PDT 
Comment on attachment 155877 [details]
Patch

Awesome!
Comment 4 WebKit Review Bot 2012-08-01 17:16:43 PDT 
Comment on attachment 155877 [details]
Patch

Clearing flags on attachment: 155877

Committed r124390: <http://trac.webkit.org/changeset/124390>
Comment 5 WebKit Review Bot 2012-08-01 17:16:47 PDT 
All reviewed patches have been landed.  Closing bug.